Skip to content

Commit f42998c

Browse files
committed
Report a bug change
1 parent ee67dfb commit f42998c

File tree

6 files changed

+7
-156
lines changed

6 files changed

+7
-156
lines changed

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountScreen.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import androidx.compose.ui.Alignment
3838
import androidx.compose.ui.Modifier
3939
import androidx.compose.ui.draw.clip
4040
import androidx.compose.ui.platform.LocalContext
41+
import androidx.compose.ui.platform.LocalUriHandler
4142
import androidx.compose.ui.res.painterResource
4243
import androidx.compose.ui.unit.dp
4344
import androidx.navigation.NavController
@@ -156,6 +157,7 @@ private fun AccountContentScreen(state: AccountUiState, navController: NavContro
156157

157158
@Composable
158159
private fun AccountItem(item: AccountItemState, navController: NavController, onLogout: () -> Unit, switchExperience: () -> Unit, modifier: Modifier = Modifier) {
160+
val uriHandler = LocalUriHandler.current
159161
Row(
160162
verticalAlignment = Alignment.CenterVertically,
161163
modifier = modifier
@@ -165,7 +167,9 @@ private fun AccountItem(item: AccountItemState, navController: NavController, on
165167
when (item.type) {
166168
is AccountItemType.Open -> navController.navigate(item.type.route.route)
167169

168-
is AccountItemType.OpenExternal -> navController.navigate(item.type.route.route)
170+
is AccountItemType.OpenExternal -> {
171+
uriHandler.openUri(item.type.url)
172+
}
169173

170174
is AccountItemType.LogOut -> {
171175
onLogout()

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountUiState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ data class AccountItemState(
4444

4545
sealed class AccountItemType(@DrawableRes val icon: Int) {
4646
data class Open(val route: AccountRoute) : AccountItemType(R.drawable.arrow_forward)
47-
data class OpenExternal(val route: AccountRoute) : AccountItemType(R.drawable.open_in_new)
47+
data class OpenExternal(val url: String) : AccountItemType(R.drawable.open_in_new)
4848
data object LogOut : AccountItemType(R.drawable.logout)
4949
data object SwitchExperience : AccountItemType(R.drawable.swap_horiz)
5050
}

libs/horizon/src/main/java/com/instructure/horizon/features/account/AccountViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ class AccountViewModel @Inject constructor(
119119
items = listOf(
120120
AccountItemState(
121121
title = context.getString(R.string.accountReportABug),
122-
type = AccountItemType.OpenExternal(AccountRoute.BugReportWebView)
122+
type = AccountItemType.OpenExternal("https://community.canvaslms.com/t5/Canvas-Career/Report-an-issue/td-p/662564")
123123
)
124124
)
125125
)

libs/horizon/src/main/java/com/instructure/horizon/features/account/navigation/AccountNavigation.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import com.instructure.horizon.features.account.notifications.AccountNotificatio
3636
import com.instructure.horizon.features.account.password.AccountPasswordScreen
3737
import com.instructure.horizon.features.account.profile.AccountProfileScreen
3838
import com.instructure.horizon.features.account.profile.AccountProfileViewModel
39-
import com.instructure.horizon.features.account.reportabug.ReportABugWebView
4039
import com.instructure.horizon.features.home.HomeNavigationRoute
4140
import com.instructure.horizon.horizonui.animation.enterTransition
4241
import com.instructure.horizon.horizonui.animation.exitTransition
@@ -91,10 +90,6 @@ fun NavGraphBuilder.accountNavigation(
9190
val uiState by viewModel.uiState.collectAsState()
9291
AccountAdvancedScreen(uiState, navController)
9392
}
94-
95-
composable(AccountRoute.BugReportWebView.route) {
96-
ReportABugWebView(navController)
97-
}
9893
}
9994
}
10095

libs/horizon/src/main/java/com/instructure/horizon/features/account/navigation/AccountRoute.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,4 @@ sealed class AccountRoute(val route: String) {
2323
data object Notifications : AccountRoute("notifications")
2424
data object CalendarFeed : AccountRoute("calendar_feed")
2525
data object Advanced : AccountRoute("advanced")
26-
data object BugReportWebView : AccountRoute("report_a_bug")
2726
}

libs/horizon/src/main/java/com/instructure/horizon/features/account/reportabug/ReportABugWebView.kt

Lines changed: 0 additions & 147 deletions
This file was deleted.

0 commit comments

Comments
 (0)