Skip to content

Commit afb6ee1

Browse files
aaronshafaaronshaf
committed
Fix KB / KiB conflation
1 parent e1e3f2a commit afb6ee1

File tree

3 files changed

+29
-26
lines changed

3 files changed

+29
-26
lines changed

‎packages/idb-cache-app/src/App.tsx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const DEFAULT_NUM_ITEMS = 1;
3636

3737
// Default item size set to 32KB
3838
const DEFAULT_ITEM_SIZE = 1024 * 32;
39-
const DEFAULT_CHUNK_SIZE = 25000;
39+
const DEFAULT_CHUNK_SIZE = 1024 * 25; // 25 KiB
4040
const DEAFULT_MAX_CHUNKS_STORED = 5000;
4141

4242
const getInitialItemSize = () => {
@@ -265,7 +265,7 @@ const App = () => {
265265

266266
<WrappedFlexItem>
267267
<NumberInput
268-
renderLabel="Size of item (KB):"
268+
renderLabel="Item size (KiB):"
269269
onChange={(e) => {
270270
const newValue = Math.max(
271271
Number.parseInt(e.target.value, 10) * 1024,
@@ -280,7 +280,7 @@ const App = () => {
280280
setItemSize((prev) => Math.max(prev - 1024, 1024));
281281
}}
282282
isRequired
283-
value={Math.round(itemSize / 1024)} // Display in KB
283+
value={Math.round(itemSize / 1024)} // Display in KiB
284284
/>
285285
</WrappedFlexItem>
286286
<WrappedFlexItem>
@@ -294,7 +294,7 @@ const App = () => {
294294
<WrappedFlexItem>
295295
<NumberInput
296296
disabled
297-
renderLabel="Chunk size (KB):"
297+
renderLabel="Chunk size (KiB):"
298298
onChange={(e) => {
299299
const newValue = Math.max(
300300
Number.parseInt(e.target.value, 10) * 1024,
@@ -308,7 +308,7 @@ const App = () => {
308308
onDecrement={() => {
309309
setChunkSize((prev) => Math.max(prev - 1024, 1024));
310310
}}
311-
value={Math.round(chunkSize / 1024)} // Display in KB
311+
value={Math.round(chunkSize / 1024)} // Display in KiB
312312
/>
313313
</WrappedFlexItem>
314314

‎packages/idb-cache-app/tests/test-4.spec.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ test("20mb size item", async ({ page }) => {
88
await expect(page.getByText("6u81xr")).toBeVisible();
99
await page.getByTestId("get-item-button").click();
1010
await expect(page.getByTestId("hash2").getByText("6u81xr")).toBeVisible();
11+
// Ensures enough time for IDB to take effect
1112
await page.getByTestId("count-button").click();
12-
await expect(page.getByText("839")).toBeVisible();
13+
await page.getByTestId("count-button").click();
14+
await page.getByTestId("count-button").click();
15+
await expect(page.getByText("820")).toBeVisible();
1316
});

‎packages/idb-cache-app/tests/test-5.spec.ts‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,45 +4,45 @@ test("maxChunks and cleanup", async ({ page }) => {
44
await page.goto("http://localhost:3000/#size=32");
55
await page.getByLabel("Max total chunks:").dblclick();
66
await page.getByLabel("Max total chunks:").fill("100");
7-
await page.getByLabel("Size of item (KB): *").dblclick();
8-
await page.getByLabel("Size of item (KB): *").press("ControlOrMeta+a");
9-
await page.getByLabel("Size of item (KB): *").fill("5");
7+
await page.getByLabel("Item size (KiB): *").dblclick();
8+
await page.getByLabel("Item size (KiB): *").press("ControlOrMeta+a");
9+
await page.getByLabel("Item size (KiB): *").fill("5");
1010
await page.goto("http://localhost:3000/#size=5");
11-
await page.getByLabel("Size of item (KB): *").fill("50");
11+
await page.getByLabel("Item size (KiB): *").fill("50");
1212
await page.goto("http://localhost:3000/#size=50");
13-
await page.getByLabel("Size of item (KB): *").fill("500");
13+
await page.getByLabel("Item size (KiB): *").fill("500");
1414
await page.goto("http://localhost:3000/#size=500");
15-
await page.getByLabel("Size of item (KB): *").press("ControlOrMeta+a");
16-
await page.getByLabel("Size of item (KB): *").press("ArrowLeft");
17-
await page.getByLabel("Size of item (KB): *").press("Shift+ArrowRight");
18-
await page.getByLabel("Size of item (KB): *").fill("800");
15+
await page.getByLabel("Item size (KiB): *").press("ControlOrMeta+a");
16+
await page.getByLabel("Item size (KiB): *").press("ArrowLeft");
17+
await page.getByLabel("Item size (KiB): *").press("Shift+ArrowRight");
18+
await page.getByLabel("Item size (KiB): *").fill("800");
1919
await page.goto("http://localhost:3000/#size=800");
20-
await page.getByLabel("Size of item (KB): *").press("ControlOrMeta+a");
21-
await page.getByLabel("Size of item (KB): *").fill("1");
20+
await page.getByLabel("Item size (KiB): *").press("ControlOrMeta+a");
21+
await page.getByLabel("Item size (KiB): *").fill("1");
2222
await page.goto("http://localhost:3000/#size=1");
23-
await page.getByLabel("Size of item (KB): *").fill("12");
23+
await page.getByLabel("Item size (KiB): *").fill("12");
2424
await page.goto("http://localhost:3000/#size=12");
25-
await page.getByLabel("Size of item (KB): *").fill("120");
25+
await page.getByLabel("Item size (KiB): *").fill("120");
2626
await page.goto("http://localhost:3000/#size=120");
27-
await page.getByLabel("Size of item (KB): *").fill("1200");
27+
await page.getByLabel("Item size (KiB): *").fill("1200");
2828
await page.goto("http://localhost:3000/#size=1200");
29-
await page.getByLabel("Size of item (KB): *").press("ArrowLeft");
30-
await page.getByLabel("Size of item (KB): *").press("ArrowLeft");
31-
await page.getByLabel("Size of item (KB): *").press("Shift+ArrowLeft");
32-
await page.getByLabel("Size of item (KB): *").fill("1300");
29+
await page.getByLabel("Item size (KiB): *").press("ArrowLeft");
30+
await page.getByLabel("Item size (KiB): *").press("ArrowLeft");
31+
await page.getByLabel("Item size (KiB): *").press("Shift+ArrowLeft");
32+
await page.getByLabel("Item size (KiB): *").fill("1300");
3333
await page.goto("http://localhost:3000/#size=1300");
3434
await page.getByTestId("set-item-button").click();
3535
// ensures enough time for IDB to take effect
3636
await page.getByTestId("count-button").click();
3737
await page.getByTestId("count-button").click();
3838
await page.getByTestId("count-button").click();
39-
await expect(page.getByText("54")).toBeVisible();
39+
await expect(page.getByText("52")).toBeVisible();
4040
await page.getByTestId("set-item-button").click();
4141
// ensures enough time for IDB to take effect
4242
await page.getByTestId("count-button").click();
4343
await page.getByTestId("count-button").click();
4444
await page.getByTestId("count-button").click();
45-
await expect(page.getByText("108")).toBeVisible();
45+
await expect(page.getByText("104")).toBeVisible();
4646
await page.getByTestId("cleanup-button").click();
4747
// ensures enough time for IDB to take effect
4848
await page.getByTestId("count-button").click();

0 commit comments

Comments
 (0)