Skip to content

Commit 36e0644

Browse files
committed
wip commit 5
1 parent 6bc7ffb commit 36e0644

File tree

62 files changed

+94
-118
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+94
-118
lines changed

packages/__docs__/src/Select/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
import { Component, Children } from 'react'
25+
import { Component, Children, ReactElement } from 'react'
2626
import PropTypes from 'prop-types'
2727

2828
import { Select as UISelect } from '@instructure/ui-select'
@@ -77,7 +77,7 @@ class Select extends Component<SelectProps, SelectState> {
7777
getOptionData(options: React.ReactElement[]) {
7878
//TODO remove any
7979
const data: any = []
80-
Children.forEach(options, (child: React.ReactElement) => {
80+
Children.forEach(options, (child: ReactElement) => {
8181
const { value, children, ...rest } = child.props
8282
data.push({ value, label: children, ...rest })
8383
})

packages/emotion/src/InstUISettingsProvider/__tests__/InstUISettingProvider.test.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,10 @@
2222
* SOFTWARE.
2323
*/
2424

25-
26-
25+
import { Component } from 'react'
2726
import { expect, mount, spy } from '@instructure/ui-test-utils'
2827
import canvas from '@instructure/ui-themes'
2928
import { InstUISettingsProvider } from '../index'
30-
import { jsx } from '../../index'
3129
import { textDirectionContextConsumer } from '@instructure/ui-i18n'
3230
import type { TextDirectionContextConsumerProps } from '@instructure/ui-i18n'
3331

packages/ui-a11y-utils/src/hasVisibleChildren.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
import { ReactNode } from 'react'
25+
import { Children, ReactNode } from 'react'
2626
import { matchComponentTypes } from '@instructure/ui-react-utils'
2727

2828
import { ScreenReaderContent } from '@instructure/ui-a11y-content'

packages/ui-alerts/src/Alert/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2222
* SOFTWARE.
2323
*/
24-
25-
import { Component } from 'react'
24+
25+
import { Fragment, Component } from 'react'
2626
import ReactDOM from 'react-dom'
2727
import keycode from 'keycode'
2828

packages/ui-breadcrumb/src/Breadcrumb/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* SOFTWARE.
2323
*/
2424

25-
26-
import { Component } from 'react'
25+
26+
import { isValidElement, cloneElement, Children, Component } from 'react'
2727

2828
import { View } from '@instructure/ui-view'
2929
import { testable } from '@instructure/ui-testable'
@@ -63,7 +63,7 @@ class Breadcrumb extends Component<BreadcrumbProps> {
6363
}
6464

6565
addAriaCurrent = (child: React.ReactNode) => {
66-
const updatedChild = React.cloneElement(
66+
const updatedChild = cloneElement(
6767
child as React.ReactElement<{ 'aria-current'?: string }>,
6868
{
6969
'aria-current': 'page'
@@ -91,7 +91,7 @@ class Breadcrumb extends Component<BreadcrumbProps> {
9191

9292
return Children.map(children, (child, index) => {
9393
const isLastElement = index === numChildren - 1
94-
if (React.isValidElement(child)) {
94+
if (isValidElement(child)) {
9595
const isCurrentPage = child.props.isCurrentPage || false
9696
if (isAriaCurrentSet && isCurrentPage) {
9797
console.warn(

packages/ui-checkbox/src/Checkbox/__new-tests__/Checkbox.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
25+
import { createRef } from 'react'
2626
import { fireEvent, render, screen, waitFor } from '@testing-library/react'
2727
import { vi } from 'vitest'
2828
import userEvent from '@testing-library/user-event'
@@ -185,7 +185,7 @@ describe('<Checkbox />', () => {
185185
})
186186

187187
it('focuses with the focus helper', () => {
188-
const checkboxRef = React.createRef<Checkbox>()
188+
const checkboxRef = createRef<Checkbox>()
189189
render(<Checkbox ref={checkboxRef} {...initProps} />)
190190
const checkboxElement = screen.getByRole('checkbox')
191191

packages/ui-code-editor/src/CodeMirrorWrapper/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
25+
import { Component } from 'react'
2626
import codemirror from 'codemirror'
2727

2828
// Language modes

packages/ui-drawer-layout/src/DrawerLayout/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
26-
import { Children, Component, createContext } from 'react'
25+
import { ComponentElement, Children, Component, createContext } from 'react'
2726

2827
import { textDirectionContextConsumer } from '@instructure/ui-i18n'
2928
import {

packages/ui-drilldown/src/Drilldown/index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
26-
27-
import { Component, ReactElement, ReactNode } from 'react'
25+
import { Children, Component, ReactElement, ReactNode } from 'react'
2826

2927
import { warn, error } from '@instructure/console'
3028
import { testable } from '@instructure/ui-testable'

packages/ui-flex/src/Flex/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
26-
import { Children, Component } from 'react'
25+
import { ComponentElement, Children, Component } from 'react'
2726

2827
import {
2928
safeCloneElement,

0 commit comments

Comments
 (0)