feat(emotion): remove as prop from InstuiSettingsProvider and remove deprecated test

Author: git-nandor

packages/emotion/src/InstUISettingsProvider/__tests__/InstUISettingsProvider.test.tsx

@@ -81,17 +81,4 @@ describe('<InstUISettingsProvider />', () => {
 
     expect(element).toHaveAttribute('dir', 'ltr')
   })
-
-  it('warns when "as" property is used without using the "dir" property', async () => {
-    const warningMessage =
-      "The 'as' property should be used in conjunction with the 'dir' property!"
-
-    render(
-      //@ts-expect-error div is required
-      <InstUISettingsProvider as="div">
-        <div>text</div>
-      </InstUISettingsProvider>
-    )
-    expect(consoleWarningMock).toHaveBeenCalledWith(warningMessage)
-  })
 })

packages/emotion/src/InstUISettingsProvider/index.tsx

@@ -32,7 +32,6 @@ import { getTheme } from '../getTheme'
 
 import type { ThemeOrOverride } from '../EmotionTypes'
 import type { DeterministicIdProviderValue } from '@instructure/ui-react-utils'
-import type { AsElementType } from '@instructure/shared-types'
 
 type InstUIProviderProps = {
   children?: React.ReactNode
@@ -50,32 +49,15 @@ type InstUIProviderProps = {
    * specific InstUI components. (generally this is used for deterministic id generation for [SSR](/#server-side-rendering))
    */
   instanceCounterMap?: DeterministicIdProviderValue
-} & (
-  | {
-      /**
-       * The text direction to use in the descendants. If not provided, it uses the following in this priority order:
-       *   - The value given in a parent `TextDirectionContext`
-       *   - The `dir` prop of `document.documentElement` or its `direction` CSS prop
-       *   - The default `ltr`
-       */
-      dir: 'ltr' | 'rtl'
-      /**
-       *  @deprecated This prop will be removed in InstUI v11
-       *
-       *  The element type to render as
-       */
-      as?: AsElementType
-    }
-  | {
-      dir?: never
-      /**
-       *  @deprecated This prop will be removed in InstUI v11
-       *
-       *  The element type to render as
-       */
-      as?: never
-    }
-)
+
+  /**
+   * The text direction to use in the descendants. If not provided, it uses the following in this priority order:
+   *   - The value given in a parent `TextDirectionContext`
+   *   - The `dir` prop of `document.documentElement` or its `direction` CSS prop
+   *   - The default `ltr`
+   */
+  dir?: 'ltr' | 'rtl'
+}
 
 /**
  * ---
@@ -87,8 +69,7 @@ function InstUISettingsProvider({
   children,
   theme = {},
   dir,
-  instanceCounterMap,
-  as
+  instanceCounterMap
 }: InstUIProviderProps) {
   const finalDir = dir || useContext(TextDirectionContext)
 
@@ -109,12 +90,7 @@ function InstUISettingsProvider({
   )
 
   if (dir) {
-    const Element = as || 'span'
-    providers = <Element dir={finalDir}>{providers}</Element>
-  } else if (as && process.env.NODE_ENV !== 'production') {
-    console.warn(
-      "The 'as' property should be used in conjunction with the 'dir' property!"
-    )
+    providers = <span dir={finalDir}>{providers}</span>
   }
 
   return providers