refactor(ui-form-field): remove border from new form errors

matyasf · matyasf · commit 6315fcb8eaa0 · 2025-02-11T14:27:38.000+01:00
diff --git a/packages/ui-form-field/src/FormFieldGroup/index.tsx b/packages/ui-form-field/src/FormFieldGroup/index.tsx
@@ -77,7 +77,13 @@ class FormFieldGroup extends Component<FormFieldGroupProps> {
   }
 
   get makeStylesVariables(): FormFieldGroupStyleProps {
-    return { invalid: this.invalid }
+    // new form errors dont need borders
+    const oldInvalid =
+      !!this.props.messages &&
+      this.props.messages.findIndex((message) => {
+        return message.type === 'error'
+      }) >= 0
+    return { invalid: oldInvalid }
   }
 
   get invalid() {

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,13 @@ class FormFieldGroup extends Component<FormFieldGroupProps> {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`get makeStylesVariables(): FormFieldGroupStyleProps {`
`80`		`- return { invalid: this.invalid }`
	`80`	`+ // new form errors dont need borders`
	`81`	`+ const oldInvalid =`
	`82`	`+ !!this.props.messages &&`
	`83`	`+ this.props.messages.findIndex((message) => {`
	`84`	`+ return message.type === 'error'`
	`85`	`+ }) >= 0`
	`86`	`+ return { invalid: oldInvalid }`
`81`	`87`	`}`
`82`	`88`
`83`	`89`	`get invalid() {`