Skip to content

Commit 6c85b31

Browse files
committed
fix(ui-menu): make Menu.Item apply target prop
1 parent 43fde61 commit 6c85b31

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/ui-menu/src/Menu/MenuItem/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,8 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
237237
}
238238

239239
render() {
240-
const { disabled, controls, onKeyDown, onKeyUp, type, href } = this.props
240+
const { disabled, controls, onKeyDown, onKeyUp, type, href, target } =
241+
this.props
241242

242243
const props = omitProps(this.props, MenuItem.allowedProps)
243244
const ElementType = this.elementType
@@ -247,6 +248,7 @@ class MenuItem extends Component<MenuItemProps, MenuItemState> {
247248
tabIndex={-1} // note: tabIndex can be overridden by Menu or MenuItemGroup components
248249
{...props}
249250
href={href}
251+
target={target}
250252
role={this.role}
251253
aria-labelledby={this.labelId}
252254
aria-disabled={disabled ? 'true' : undefined}

0 commit comments

Comments
 (0)