Skip to content

Commit 72af55e

Browse files
committed
fix(ui-byline): remove figure and figcaption
INSTUI-4549
1 parent c221a97 commit 72af55e

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

packages/ui-byline/src/Byline/__new-tests__/Byline.test.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,6 @@ describe('<Byline />', () => {
128128
expect(axeCheck).toBe(true)
129129
})
130130

131-
it(`should render a figure by default`, () => {
132-
renderByline()
133-
const figureElement = screen.getByRole('figure')
134-
135-
expect(figureElement).toBeInTheDocument()
136-
})
137-
138131
describe('when passing down props to View', () => {
139132
const customAllowedProps: { [key: string]: string } = { margin: 'small' }
140133
const customIgnoredProps = ['elementRef', 'children']

packages/ui-byline/src/Byline/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,11 @@ class Byline extends Component<BylineProps> {
8282
{...passthroughProps}
8383
elementRef={this.handleRef}
8484
css={this.props.styles?.byline}
85-
as="figure"
8685
margin={this.props.margin}
8786
maxWidth={this.props.styles?.maxWidth}
8887
>
8988
<div css={this.props.styles?.figure}>{this.props.children}</div>
90-
<figcaption css={this.props.styles?.caption}>
89+
<div css={this.props.styles?.caption}>
9190
{this.props.title && (
9291
<span css={this.props.styles?.title}>{this.props.title}</span>
9392
)}
@@ -96,7 +95,7 @@ class Byline extends Component<BylineProps> {
9695
{this.props.description}
9796
</div>
9897
)}
99-
</figcaption>
98+
</div>
10099
</View>
101100
)
102101
}

0 commit comments

Comments
 (0)