Skip to content

Commit 78aec71

Browse files
committed
fix(many): hide required asterisks from screenreaders
1 parent dd1e12c commit 78aec71

File tree

7 files changed

+44
-8
lines changed

7 files changed

+44
-8
lines changed

packages/ui-checkbox/src/Checkbox/CheckboxFacade/theme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const generateComponentTheme = (theme: Theme): CheckboxFacadeTheme => {
4848
color: colors?.contrasts?.white1010,
4949
borderWidth: borders?.widthSmall,
5050
borderColor: colors?.contrasts?.grey3045,
51-
errorBorderColor: colors?.ui?.textError,
51+
errorBorderColor: colors?.contrasts?.red5782,
5252
borderRadius: borders?.radiusMedium,
5353
background: colors?.contrasts?.white1010,
5454
marginRight: spacing?.xSmall,

packages/ui-checkbox/src/Checkbox/ToggleFacade/theme.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const generateComponentTheme = (theme: Theme): ToggleFacadeTheme => {
5454

5555
const componentVariables: ToggleFacadeTheme = {
5656
color: colors?.contrasts?.white1010,
57-
errorBorderColor: colors?.ui?.textError,
57+
errorBorderColor: colors?.contrasts?.red5782,
5858
background: colors?.contrasts?.grey1111,
5959
borderColor: colors?.contrasts?.grey3045,
6060
borderWidth: borders?.widthSmall,

packages/ui-checkbox/src/Checkbox/index.tsx

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,13 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> {
231231
>
232232
{label}
233233
{isRequired && label && (
234-
<span css={this.invalid ? styles?.requiredInvalid : {}}> *</span>
234+
<span
235+
css={this.invalid ? styles?.requiredInvalid : {}}
236+
aria-hidden={true}
237+
>
238+
{' '}
239+
*
240+
</span>
235241
)}
236242
</ToggleFacade>
237243
)
@@ -248,7 +254,13 @@ class Checkbox extends Component<CheckboxProps, CheckboxState> {
248254
>
249255
{label}
250256
{isRequired && label && (
251-
<span css={this.invalid ? styles?.requiredInvalid : {}}> *</span>
257+
<span
258+
css={this.invalid ? styles?.requiredInvalid : {}}
259+
aria-hidden={true}
260+
>
261+
{' '}
262+
*
263+
</span>
252264
)}
253265
</CheckboxFacade>
254266
)

packages/ui-number-input/src/NumberInput/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,13 @@ class NumberInput extends Component<NumberInputProps, NumberInputState> {
248248
<React.Fragment>
249249
{rawLabel}
250250
{isRequired && (
251-
<span css={this.invalid ? styles?.requiredInvalid : {}}> *</span>
251+
<span
252+
css={this.invalid ? styles?.requiredInvalid : {}}
253+
aria-hidden={true}
254+
>
255+
{' '}
256+
*
257+
</span>
252258
)}
253259
</React.Fragment>
254260
) : (

packages/ui-radio-input/src/RadioInputGroup/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,13 @@ class RadioInputGroup extends Component<
165165
<React.Fragment>
166166
{description}
167167
{isRequired && description && (
168-
<span css={this.invalid ? styles?.invalidAsterisk : {}}> *</span>
168+
<span
169+
css={this.invalid ? styles?.invalidAsterisk : {}}
170+
aria-hidden={true}
171+
>
172+
{' '}
173+
*
174+
</span>
169175
)}
170176
</React.Fragment>
171177
) : (

packages/ui-text-area/src/TextArea/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,13 @@ class TextArea extends Component<TextAreaProps> {
358358
<React.Fragment>
359359
{this.props.label}
360360
{required && (
361-
<span css={this.invalid ? styles?.requiredInvalid : {}}> *</span>
361+
<span
362+
css={this.invalid ? styles?.requiredInvalid : {}}
363+
aria-hidden={true}
364+
>
365+
{' '}
366+
*
367+
</span>
362368
)}
363369
</React.Fragment>
364370
) : (

packages/ui-text-input/src/TextInput/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,13 @@ class TextInput extends Component<TextInputProps, TextInputState> {
333333
<React.Fragment>
334334
{rawLabel}
335335
{isRequired && (
336-
<span css={this.invalid ? styles?.requiredInvalid : {}}> *</span>
336+
<span
337+
css={this.invalid ? styles?.requiredInvalid : {}}
338+
aria-hidden={true}
339+
>
340+
{' '}
341+
*
342+
</span>
337343
)}
338344
</React.Fragment>
339345
) : (

0 commit comments

Comments
 (0)