Skip to content

Commit a0d7075

Browse files
committed
fix(ui-table): fix selectable table screen reader issue on select all checkbox in the column header
1 parent 5ae9806 commit a0d7075

File tree

2 files changed

+39
-5
lines changed

2 files changed

+39
-5
lines changed

package-lock.json

Lines changed: 31 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/ui-table/src/Table/README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -976,10 +976,12 @@ that selection does not re-paginate or re-sort the table, and pagination does no
976976
}
977977
>
978978
<Table.Row>
979-
<Table.ColHeader id="select">
979+
<Table.ColHeader id="select" aria-label="Select">
980980
<Checkbox
981981
label={
982-
<ScreenReaderContent>Select all</ScreenReaderContent>
982+
<ScreenReaderContent>
983+
Select all rows
984+
</ScreenReaderContent>
983985
}
984986
onChange={() => this.handleSelectAll(allSelected)}
985987
checked={allSelected}
@@ -1315,10 +1317,12 @@ that selection does not re-paginate or re-sort the table, and pagination does no
13151317
}
13161318
>
13171319
<Table.Row>
1318-
<Table.ColHeader id="select">
1320+
<Table.ColHeader id="select" aria-label="Select">
13191321
<Checkbox
13201322
label={
1321-
<ScreenReaderContent>Select all</ScreenReaderContent>
1323+
<ScreenReaderContent>
1324+
Select all rows
1325+
</ScreenReaderContent>
13221326
}
13231327
onChange={() => handleSelectAll(allSelected)}
13241328
checked={allSelected}

0 commit comments

Comments
 (0)