Skip to content

Commit de22f76

Browse files
committed
fix(ui-progress,ui-tag): remove onClick prop from Tag when callback is not provided. Fix Progress dependency mismatch (test-locator)
Closes: INSTUI-4332
1 parent bf9d66d commit de22f76

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

packages/ui-progress/tsconfig.build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
{ "path": "../ui-testable/tsconfig.build.json" },
1818
{ "path": "../ui-view/tsconfig.build.json" },
1919
{ "path": "../ui-babel-preset/tsconfig.build.json" },
20-
{ "path": "../ui-test-locator/tsconfig.build.json" },
2120
{ "path": "../ui-test-utils/tsconfig.build.json" },
2221
{ "path": "../ui-themes/tsconfig.build.json" }
2322
]

packages/ui-tag/src/Tag/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class Tag extends Component<TagProps> {
122122
as={onClick ? 'button' : 'span'}
123123
margin={margin}
124124
type={onClick ? 'button' : undefined}
125-
onClick={onClick ?? this.handleClick}
125+
{...(onClick && { onClick: this.handleClick })}
126126
disabled={disabled || readOnly}
127127
display={undefined}
128128
title={title || (typeof text === 'string' ? text : undefined)}

0 commit comments

Comments
 (0)