fix(ui-react-utils): fix an edge-case where safeCloneElement breaks with non-functional refs

HerrTopi · HerrTopi · commit fa78679d7f96 · 2025-07-04T12:44:31.000+02:00
INSTUI-4633
diff --git a/packages/ui-react-utils/src/safeCloneElement.ts b/packages/ui-react-utils/src/safeCloneElement.ts
@@ -114,7 +114,8 @@ Ignoring ref: ${originalRef}`
         } else {
           cloneRef.current = component
         }
-        originalRef(component)
+
+        originalRefIsAFunction && originalRef(component)
       }
     },
     ...children

Original file line number	Diff line number	Diff line change
@@ -114,7 +114,8 @@ Ignoring ref: ${originalRef}`
`114`	`114`	`} else {`
`115`	`115`	`cloneRef.current = component`
`116`	`116`	`}`
`117`		`- originalRef(component)`
	`117`	`+`
	`118`	`+ originalRefIsAFunction && originalRef(component)`
`118`	`119`	`}`
`119`	`120`	`},`
`120`	`121`	`...children`