Skip to content

Commit 52cdc66

Browse files
authored
Shared configs/workflows/release package (#138)
* fix tests * fix build script * support packages and apps in release * [email protected] * [email protected] * [email protected]
1 parent 8d4ca35 commit 52cdc66

File tree

7 files changed

+17
-20
lines changed

7 files changed

+17
-20
lines changed

.github/workflows/release-package.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ jobs:
102102
# Build & test (skip for shared-configs)
103103
if [ "$PKG_NAME" != "shared-configs" ]; then
104104
echo "Building package: $PKG_NAME"
105-
pnpm test package "$PKG_NAME"
106-
pnpm build package "$PKG_NAME"
105+
pnpm test "$PKG_NAME"
106+
pnpm build "$PKG_NAME"
107107
else
108108
echo "Skipping build/test for @instructure.ai/shared-configs."
109109
fi

apps/nutritionfacts/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
# @instructure.ai/nutritionfacts
32

43
## IgniteAI Nutrition Facts Generator

apps/nutritionfacts/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"url": "https://github.com/instructure/instructure.ai"
2020
},
2121
"scripts": {
22-
"build": "pnpm update-cache && vite build",
22+
"build": "vite build",
2323
"dev": "vite",
2424
"lint": "pnpm biome check",
2525
"preview": "vite preview",
@@ -28,5 +28,5 @@
2828
"update-cache": "vite-node ./scripts/updateCache.mts"
2929
},
3030
"type": "module",
31-
"version": "1.4.2"
31+
"version": "1.4.3"
3232
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"vitest": "^3.2.4",
2323
"yaml": "^2.8.1"
2424
},
25-
"version": "1.4.2",
25+
"version": "1.4.3",
2626
"name": "@instructure.ai/shared-configs",
2727
"packageManager": "[email protected]",
2828
"private": true,

packages/aiinfo/coverage/coverage.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
coverage:
22
totals:
3-
statements: 96.14%
4-
branches: 87.11%
3+
statements: 93.76%
4+
branches: 84.53%
55
functions: 100%
6-
lines: 96%
7-
total: 94.81%
6+
lines: 93.53%
7+
total: 92.96%
88
scripts:
99
totals:
10-
statements: 96.2%
11-
branches: 88.46%
10+
statements: 91.85%
11+
branches: 78.85%
1212
functions: 100%
13-
lines: 96.2%
13+
lines: 91.85%
1414
"clearCache.mts":
1515
statements: 100%
1616
branches: 100%
1717
functions: 100%
1818
lines: 100%
1919
"updateCache.mts":
20-
statements: 92.39%
21-
branches: 76.92%
20+
statements: 83.69%
21+
branches: 57.69%
2222
functions: 100%
23-
lines: 92.39%
24-
uncovered_line_numbers: "50-188"
23+
lines: 83.69%
24+
uncovered_line_numbers: "50-214"
2525
strings:
2626
totals:
2727
statements: 100%

packages/aiinfo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@
5050
"sideEffects": false,
5151
"type": "module",
5252
"types": "./dist/index.d.ts",
53-
"version": "1.4.2"
53+
"version": "1.4.3"
5454
}

packages/aiinfo/scripts/updateCache.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ describe("updateCache.mts parseCSV", () => {
182182
});
183183

184184
describe("main behavior without side-effect", () => {
185-
186185
it("returns true and updates cache when CSV changed", async () => {
187186
const oldCSV = "uid1,name1,desc1\nuid2,name2,desc2";
188187
const newCSV = "uid1,name1,desc1-mod\nuid2,name2,desc2";
@@ -252,7 +251,6 @@ describe("main behavior without side-effect", () => {
252251
});
253252

254253
describe("side-effect import with UPDATE env", () => {
255-
256254
it("exits with code 0 when cache updated", async () => {
257255
const oldCSV = "uid1,name1,desc1";
258256
const newCSV = "uid1,name1,desc1-mod";

0 commit comments

Comments
 (0)