Skip to content

Commit 3406436

Browse files
committed
fix task_qc_viewer tests
1 parent bbd9355 commit 3406436

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ibllib/tests/qc/test_task_qc_viewer.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from ibllib.qc.task_qc_viewer.task_qc import get_bpod_trials_task, show_session_task_qc, QcFrame
1111
from ibllib.qc.task_metrics import TaskQC
1212
from ibllib.tests import TEST_DB
13+
from one.alf import spec
1314

1415

1516
MOCK_QT = os.environ.get('IBL_MOCK_QT', True)
@@ -63,12 +64,13 @@ def test_show_session_task_qc(self, trials_tasks_mock, run_app_mock):
6364
# Set up QC mock
6465
qc_mock = mock.Mock(spec=TaskQC, unsafe=True)
6566
qc_mock.metrics = {'foo': .7}
66-
qc_mock.compute_session_status.return_value = ('Fail', qc_mock.metrics, {'foo': 'FAIL'})
67+
qc_mock.compute_session_status.return_value = (spec.QC(40), qc_mock.metrics, {'foo': spec.QC(40)})
6768
qc_mock.extractor.data = {'intervals': np.array([[0, 1]])}
6869
qc_mock.extractor.frame_ttls = qc_mock.extractor.audio_ttls = qc_mock.extractor.bpod_ttls = mock.MagicMock()
6970
qc_mock.passed = dict()
7071

7172
active_task = mock.Mock(spec=ChoiceWorldTrialsNidq, unsafe=True)
73+
active_task.extract_behaviour.return_value = [None, None]
7274
active_task.run_qc.return_value = qc_mock
7375
active_task.name = 'Trials_activeChoiceWorld_01'
7476
trials_tasks_mock.return_value = [passive_task, active_task]
@@ -77,7 +79,7 @@ def test_show_session_task_qc(self, trials_tasks_mock, run_app_mock):
7779
self.assertIsInstance(qc, QcFrame)
7880
self.assertIsInstance(qc.qc, TaskQC)
7981
self.assertCountEqual(qc.get_wheel_data(), ('re_ts', 're_pos'))
80-
active_task.run_qc.assert_called_once_with(update=False)
82+
active_task.run_qc.assert_called_once_with(trials_data=None, update=False)
8183
self.assertEqual('remote', active_task.location)
8284
active_task.setUp.assert_called_once()
8385
active_task.assert_expected_inputs.assert_not_called()

0 commit comments

Comments
 (0)