Skip to content

Commit 3a61727

Browse files
committed
use scratch dir for pykilosort
1 parent cecd39c commit 3a61727

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

ibllib/io/extractors/signatures.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@
182182
('*.ch', 'raw_ephys_data/probe*', True),
183183
('*.cbin', 'raw_ephys_data/probe*', True)]
184184

185+
185186
def spike_sorting_signature(pname=None):
186187
pname = pname if pname is not None else "probe*"
187188
signature = [('*ap.meta', f'raw_ephys_data/{pname}', True),
@@ -192,5 +193,5 @@ def spike_sorting_signature(pname=None):
192193
('_spikeglx_sync.times.*', 'raw_ephys_data*', True)]
193194
return signature
194195

195-
SPIKESORTING = [spike_sorting_signature()]
196196

197+
SPIKESORTING = [spike_sorting_signature()]

ibllib/oneibl/aws.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def _download_datasets(self, datasets):
4141
if file_path.exists():
4242
# already downloaded, need to have some options for overwrite, clobber, look
4343
# for file mismatch like in ONE
44-
_logger.warning(f'{file_path} already exists wont redownload')
44+
_logger.info(f'{file_path} already exists wont redownload')
4545
continue
4646

4747
aws_path = AWS_ROOT_PATH.joinpath(add_uuid_string(rel_file_path,

ibllib/pipes/ephys_preprocessing.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,17 @@ def _fetch_ks2_commit_hash(repo_path):
134134
return info.decode("utf-8").strip()
135135

136136
def _run_pykilosort(self, ap_file):
137-
f"""
137+
"""
138138
Runs the ks2 matlab spike sorting for one probe dataset
139-
the raw spike sorting output can either be with the probe (<1.5.5) or in the
140-
session_path/spike_sorters/{self.SPIKE_SORTER_NAME}/probeXX folder
139+
the raw spike sorting output is in session_path/spike_sorters/{self.SPIKE_SORTER_NAME}/probeXX folder
140+
(discontinued support for old spike sortings in the probe folder <1.5.5)
141141
:return: path of the folder containing ks2 spike sorting output
142142
"""
143143
self.version = self._fetch_pykilosort_version(self.PYKILOSORT_REPO)
144144
label = ap_file.parts[-2] # this is usually the probe name
145145
sorter_dir = self.session_path.joinpath("spike_sorters", self.SPIKE_SORTER_NAME, label)
146146
FORCE_RERUN = False
147147
if not FORCE_RERUN:
148-
if ap_file.parent.joinpath(f"spike_sorting_{self.SPIKE_SORTER_NAME}.log").exists():
149-
_logger.info(f"Already ran: spike_sorting_{self.SPIKE_SORTER_NAME}.log"
150-
f" found for {ap_file}, skipping.")
151-
return ap_file.parent
152148
if sorter_dir.joinpath(f"spike_sorting_{self.SPIKE_SORTER_NAME}.log").exists():
153149
_logger.info(f"Already ran: spike_sorting_{self.SPIKE_SORTER_NAME}.log"
154150
f" found in {sorter_dir}, skipping.")

0 commit comments

Comments
 (0)