Skip to content

Commit 9fea20e

Browse files
committed
scipy >= 0.13.0 windows refactoring. Closes #753
1 parent 411c494 commit 9fea20e

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

brainbox/population/cca.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import numpy as np
22
import matplotlib.pylab as plt
3+
from scipy.signal.windows import gaussian
4+
from scipy.signal import convolve
5+
from sklearn.decomposition import PCA
6+
37
from iblutil.numerical import bincount2D
48

59

610
def _smooth(data, sd):
7-
from scipy.signal import gaussian
8-
from scipy.signal import convolve
11+
912
n_bins = data.shape[0]
1013
w = n_bins - 1 if n_bins % 2 == 0 else n_bins
1114
window = gaussian(w, std=sd)
@@ -15,7 +18,6 @@ def _smooth(data, sd):
1518

1619

1720
def _pca(data, n_pcs):
18-
from sklearn.decomposition import PCA
1921
pca = PCA(n_components=n_pcs)
2022
pca.fit(data)
2123
data_pc = pca.transform(data)

brainbox/singlecell.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
'''
44

55
import numpy as np
6-
from scipy.signal import convolve, gaussian
6+
from scipy.signal import convolve
7+
from scipy.signal.windows import gaussian
78
from iblutil.util import Bunch
89
from brainbox.population.decode import xcorr
910

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ pynrrd>=0.4.0
1515
pytest
1616
requests>=2.22.0
1717
scikit-learn>=0.22.1
18-
scipy>=1.7.0,<1.13 # scipy gaussian missing April 2024
18+
scipy>=1.7.0
1919
scikit-image # this is a widefield requirement missing as of July 2023, we may remove it once wfield has this figured out
2020
sparse
2121
seaborn>=0.9.0

0 commit comments

Comments
 (0)