Registration test fix - ensure start time updated

Author: k1o0

.github/workflows/ibllib_ci.yml

@@ -24,6 +24,8 @@ jobs:
             python-version: 3.10
           - os: ubuntu-latest
             python-version: 3.12
+    env:
+      ONE_SAVE_ON_DELETE: false
     steps:
     - uses: actions/checkout@v2
     - name: Set up Python ${{ matrix.python-version }}

ibllib/oneibl/registration.py

@@ -10,13 +10,9 @@
 from one.registration import RegistrationClient, get_dataset_type
 from one.remote.globus import get_local_endpoint_id, get_lab_from_endpoint_id
 from one.webclient import AlyxClient, no_cache
-from one.converters import ConversionMixin
+from one.converters import ConversionMixin, datasets2records
 import one.alf.exceptions as alferr
 from one.api import ONE
-try:
-    from one.util import datasets2records
-except ImportError:
-    from one.converters import datasets2records
 from iblutil.util import ensure_list
 
 import ibllib
@@ -249,13 +245,13 @@ def register_session(self, ses_path, file_list=True, projects=None, procedures=N
             missing = [k for k in required if not session_details[k]]
             assert not any(missing), 'missing session information: ' + ', '.join(missing)
             task_protocols = task_data = settings = []
-            json_field = end_time = None
+            json_field = start_time = end_time = None
             users = session_details['users']
             n_trials = n_correct_trials = 0
         else:  # Get session info from task data
-            collections = ensure_list(collections)
+            collections = sorted(ensure_list(collections))
             # read meta data from the rig for the session from the task settings file
-            task_data = (raw.load_bpod(ses_path, collection) for collection in sorted(collections))
+            task_data = (raw.load_bpod(ses_path, collection) for collection in collections)
             # Filter collections where settings file was not found
             if not (task_data := list(zip(*filter(lambda x: x[0] is not None, task_data)))):
                 raise ValueError(f'_iblrig_taskSettings.raw.json not found in {ses_path} Abort.')
@@ -342,6 +338,8 @@ def register_session(self, ses_path, file_list=True, projects=None, procedures=N
                 data['task_protocol'] = '/'.join(task_protocols)
             if end_time:
                 data['end_time'] = self.ensure_ISO8601(end_time)
+            if start_time:
+                data['start_time'] = self.ensure_ISO8601(start_time)
 
             session = self.one.alyx.rest('sessions', 'partial_update', id=session_id[0], data=data)
             if json_field:

ibllib/tests/test_oneibl.py

@@ -527,7 +527,7 @@ def test_register_chained_session(self):
     def tearDown(self) -> None:
         self.td.cleanup()
         self.one.alyx.rest('revisions', 'delete', id=self.rev['name'])
-        self.one.alyx.rest('tags', 'delete', id=self.tag['id'])
+        self.one.alyx.rest('tags', 'delete', id=self.tag['name'])
         today_revision = self.one.alyx.rest('revisions', 'list', id=self.today_revision)
         today_rev = [rev for rev in today_revision if self.today_revision in rev['name']]
         for rev in today_rev: