Merge branch 'hotfix/3.4.1' into develop

Author: oliche

release_notes.md CHANGELOG.mdrelease_notes.md renamed to CHANGELOG.md

@@ -1,3 +1,20 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+
+
+## [3.4.1] 2025-07-02
+
+### Fixed
+
+- SpikeSortingLoader takes into account revisions
+- There is a specific test for `spikeinterface` CI in our integration tests
+
+
 ## Release Note 3.4.0
 
 ### features

README.md

@@ -9,7 +9,7 @@ The library is currently 2 main modules:
 -   **brainbox**: neuroscience analysis oriented library
 -   **ibllib**: general purpose library containing I/O, signal processing and IBL data pipelines utilities.
 
-[Release Notes here](release_notes.md)
+[Release Notes here](CHANGELOG.md)
 
 ## Requirements
 **OS**: Only tested on Linux. Windows and Mac may work, but are not supported.
@@ -26,9 +26,10 @@ See https://int-brain-lab.github.io/iblenv/07_contribution.html
 We use Semantic Versioning.
 
 Before committing to your branch:
--   run tests
--   flake8
-This is also enforced by continuous integration.
+-   check formating `flake8`
+-   run tests `python -m unittest discover`
+
+Pull request to `develop` or `main`.
 
 
 ## Matlab Library

brainbox/io/one.py

@@ -715,7 +715,7 @@ def load_spike_sorting_object(self, obj, *args, revision=None, **kwargs):
         :return:
         """
         revision = revision if revision is not None else self.revision
-        self.download_spike_sorting_object(obj, *args, **kwargs)
+        self.download_spike_sorting_object(obj, *args, revision=revision, **kwargs)
         return self._load_object(self.files[obj])
 
     def get_version(self, spike_sorter=None):
@@ -750,7 +750,7 @@ def download_spike_sorting_object(self, obj, spike_sorter=None, dataset_types=No
         try:
             self.files[obj] = self.one.load_object(
                 self.eid, obj=obj, attribute=attributes.get(obj, None),
-                collection=collection, download_only=True, **kwargs)
+                collection=collection, download_only=True, revision=revision, **kwargs)
         except ALFObjectNotFound as e:
             if missing == 'raise':
                 raise e

ibllib/__init__.py

@@ -2,7 +2,7 @@
 import logging
 import warnings
 
-__version__ = '3.4.0'
+__version__ = '3.4.1'
 warnings.filterwarnings('always', category=DeprecationWarning, module='ibllib')
 
 # if this becomes a full-blown library we should let the logging configuration to the discretion of the dev