use weakref.finalize to close plots

Author: bimac

iblrig/base_choice_world.py

@@ -818,7 +818,7 @@ def _run(self):
             )
         super()._run()
 
-    def __del__(self):
+    def _finalize(self):
         if isinstance(self.plot_subprocess, subprocess.Popen) and self.plot_subprocess.poll() is None:
             log.info('Terminating subprocess: online plots')
             self.plot_subprocess.terminate()

iblrig/base_tasks.py

@@ -16,6 +16,7 @@
 import sys
 import time
 import traceback
+import weakref
 from abc import ABC, abstractmethod
 from collections import OrderedDict
 from collections.abc import Callable
@@ -201,6 +202,10 @@ def __init__(
             stub,
             extractors=self.extractor_tasks,
         )
+        self.finalize = weakref.finalize(self, self._finalize)
+
+    def _finalize(self):  # noqa: B027
+        """Clean-up tasks prior to destroying the object"""
 
     @property
     def session_path(self) -> Path | None: