Skip to content

Commit de283b3

Browse files
authored
Merge pull request #235 from Akxe/Memory_leak_fix#2
Fix memory leak on component destroy
2 parents 00cd641 + c914ed9 commit de283b3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

lib/src/ng2-pdfjs-viewer.component.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { Component, Input, Output, OnInit, ViewChild, EventEmitter, ElementRef } from '@angular/core';
1+
import { Component, Input, Output, OnInit, OnDestroy, ViewChild, EventEmitter, ElementRef } from '@angular/core';
22

33
@Component({
44
selector: 'ng2-pdfjs-viewer',
55
template: `<iframe title="ng2-pdfjs-viewer" [hidden]="externalWindow || (!externalWindow && !pdfSrc)" #iframe width="100%" height="100%"></iframe>`
66
})
7-
export class PdfJsViewerComponent implements OnInit {
7+
export class PdfJsViewerComponent implements OnInit, OnDestroy {
88
@ViewChild('iframe', { static: true }) iframe: ElementRef;
99
static lastID = 0;
1010
@Input() public viewerId = `ng2-pdfjs-viewer-ID${++PdfJsViewerComponent.lastID}`;
@@ -341,4 +341,8 @@ export class PdfJsViewerComponent implements OnInit {
341341
// pagemode = ${this.errorMessage}
342342
// `);
343343
}
344+
345+
ngOnDestroy(): void {
346+
this.relaseUrl?.();
347+
}
344348
}

0 commit comments

Comments
 (0)