Skip to content

Commit 14560df

Browse files
committed
Remove discussion of tokio coop
1 parent be38639 commit 14560df

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

datafusion/physical-plan/src/execution_plan.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,11 +263,9 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
263263
/// To enable timely cancellation, the [`Stream`] that is returned must not
264264
/// pin the CPU and must yield back to the tokio runtime regularly. This can
265265
/// be achieved by manually returning [`Poll::Pending`] in regular intervals,
266-
/// or the use of [`tokio::task::yield_now()`]. Cooperative scheduling may also
267-
/// be a way to achieve this goal, as [tokio support for it improves][coop].
268-
/// Determination for "regularly" may be made using a timer (being careful with
269-
/// the overhead-heavy syscall needed to take the time) or by counting rows or
270-
/// batches.
266+
/// or the use of [`tokio::task::yield_now()`]. Determination for "regularly"
267+
/// may be made using a timer (being careful with the overhead-heavy syscall
268+
/// needed to take the time) or by counting rows or batches.
271269
///
272270
/// The goal is for `datafusion`-provided operator implementation to
273271
/// strive for [the guideline of not spending a long time without reaching
@@ -282,7 +280,6 @@ pub trait ExecutionPlan: Debug + DisplayAs + Send + Sync {
282280
/// [`SpawnedTask`]: datafusion_common_runtime::SpawnedTask
283281
/// [`RecordBatchReceiverStreamBuilder`]: crate::stream::RecordBatchReceiverStreamBuilder
284282
/// [`Poll::Pending`]: std::task::Poll::Pending
285-
/// [coop]: https://github.com/tokio-rs/tokio/pull/7116
286283
/// [async-guideline]: https://ryhl.io/blog/async-what-is-blocking/
287284
///
288285
/// # Implementation Examples

0 commit comments

Comments
 (0)