Add missing nullability annotations

Author: cirras

delphi-checks/src/main/java/au/com/integradev/delphi/checks/CommentedOutCodeCheck.java

@@ -27,6 +27,7 @@
 import java.util.List;
 import java.util.Set;
 import java.util.regex.Pattern;
+import javax.annotation.Nonnull;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.sonar.check.Rule;
@@ -249,11 +250,13 @@ public int length() {
     }
 
     @Override
+    @Nonnull
     public CharSequence subSequence(int start, int end) {
       return new RegexTimeoutCharSequence(sequence.subSequence(start, end), deadline);
     }
 
     @Override
+    @Nonnull
     public String toString() {
       return sequence.toString();
     }

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/ArrayTypeNodeImpl.java

@@ -46,6 +46,7 @@ public <T> T accept(DelphiParserVisitor<T> visitor, T data) {
   }
 
   @Override
+  @Nonnull
   public TypeNode getElementTypeNode() {
     return (TypeNode) getChild(1);
   }

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/ConstDeclarationNodeImpl.java

@@ -19,6 +19,7 @@
 package au.com.integradev.delphi.antlr.ast.node;
 
 import au.com.integradev.delphi.antlr.ast.visitors.DelphiParserVisitor;
+import javax.annotation.Nonnull;
 import org.antlr.runtime.Token;
 import org.sonar.plugins.communitydelphi.api.ast.AttributeListNode;
 import org.sonar.plugins.communitydelphi.api.ast.ConstDeclarationNode;
@@ -65,6 +66,7 @@ public AttributeListNode getAttributeList() {
   }
 
   @Override
+  @Nonnull
   public Type getType() {
     TypeNode typeNode = getTypeNode();
     if (typeNode != null) {

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/declaration/EnumElementNameDeclarationImpl.java

@@ -19,6 +19,7 @@
 package au.com.integradev.delphi.symbol.declaration;
 
 import java.util.Objects;
+import javax.annotation.Nonnull;
 import org.sonar.plugins.communitydelphi.api.ast.EnumElementNode;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.EnumElementNameDeclaration;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.NameDeclaration;
@@ -49,7 +50,7 @@ public int hashCode() {
   }
 
   @Override
-  public int compareTo(NameDeclaration other) {
+  public int compareTo(@Nonnull NameDeclaration other) {
     int result = super.compareTo(other);
     if (result == 0) {
       EnumElementNameDeclarationImpl that = (EnumElementNameDeclarationImpl) other;

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/declaration/PropertyNameDeclarationImpl.java

@@ -26,6 +26,7 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.stream.Collectors;
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import org.sonar.plugins.communitydelphi.api.ast.AttributeListNode;
 import org.sonar.plugins.communitydelphi.api.ast.DelphiNode;
@@ -312,7 +313,7 @@ public int hashCode() {
   }
 
   @Override
-  public int compareTo(NameDeclaration other) {
+  public int compareTo(@Nonnull NameDeclaration other) {
     int result = super.compareTo(other);
     if (result == 0) {
       PropertyNameDeclarationImpl that = (PropertyNameDeclarationImpl) other;

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/declaration/RoutineNameDeclarationImpl.java

@@ -33,6 +33,7 @@
 import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import org.sonar.plugins.communitydelphi.api.ast.AttributeListNode;
 import org.sonar.plugins.communitydelphi.api.ast.DelphiNode;
@@ -328,7 +329,7 @@ public int hashCode() {
   }
 
   @Override
-  public int compareTo(NameDeclaration other) {
+  public int compareTo(@Nonnull NameDeclaration other) {
     int result = super.compareTo(other);
     if (result == 0) {
       RoutineNameDeclarationImpl that = (RoutineNameDeclarationImpl) other;

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/declaration/UnitNameDeclarationImpl.java

@@ -23,6 +23,7 @@
 import java.util.HashSet;
 import java.util.Objects;
 import java.util.Set;
+import javax.annotation.Nonnull;
 import org.sonar.plugins.communitydelphi.api.ast.FileHeaderNode;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.NameDeclaration;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.UnitNameDeclaration;
@@ -114,7 +115,7 @@ public int hashCode() {
   }
 
   @Override
-  public int compareTo(NameDeclaration other) {
+  public int compareTo(@Nonnull NameDeclaration other) {
     int result = super.compareTo(other);
     if (result == 0) {
       UnitNameDeclarationImpl that = (UnitNameDeclarationImpl) other;

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/scope/TypeScopeImpl.java

@@ -23,6 +23,7 @@
 
 import au.com.integradev.delphi.type.generic.GenerifiableTypeImpl;
 import java.util.Set;
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import org.sonar.plugins.communitydelphi.api.symbol.NameOccurrence;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.NameDeclaration;
@@ -105,7 +106,7 @@ public void addDeclaration(NameDeclaration declaration) {
     }
 
     @Override
-    public Set<NameDeclaration> addNameOccurrence(NameOccurrence occurrence) {
+    public Set<NameDeclaration> addNameOccurrence(@Nonnull NameOccurrence occurrence) {
       return ((DelphiScopeImpl) genericScope).addNameOccurrence(occurrence);
     }
   }