Detect tab-indented multiline strings in TabulationCharacter

Author: cirras

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Detect tab-indented multiline strings in `TabulationCharacter`.
 - Improve support for evaluating name references in compiler directive expressions.
 
 ### Fixed

delphi-checks/src/main/java/au/com/integradev/delphi/checks/TabulationCharacterCheck.java

@@ -25,6 +25,7 @@
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheck;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheckContext;
 import org.sonar.plugins.communitydelphi.api.token.DelphiToken;
+import org.sonar.plugins.communitydelphi.api.token.DelphiTokenType;
 import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 @DeprecatedRuleKey(ruleKey = "TabulationCharactersRule", repositoryKey = "delph")
@@ -54,5 +55,21 @@ public void visitToken(DelphiToken token, DelphiCheckContext context) {
     if (token.isWhitespace()) {
       tabCount += countMatches(token.getImage(), '\t');
     }
+
+    if (token.getType() == DelphiTokenType.MULTILINE_STRING) {
+      String lastLine = context.getFileLines().get(token.getEndLine() - 1);
+      int tabs = 0;
+
+      for (int i = 0; i < lastLine.length(); ++i) {
+        char c = lastLine.charAt(i);
+        if (c == '\t') {
+          ++tabs;
+        } else if (c == '\'') {
+          break;
+        }
+      }
+
+      tabCount += tabs * (token.getEndLine() - token.getBeginLine());
+    }
   }
 }

delphi-checks/src/test/java/au/com/integradev/delphi/checks/TabulationCharacterCheckTest.java

@@ -52,4 +52,17 @@ void testFileWithMultipleTabsShouldAddIssue() {
                 .appendDecl("\t"))
         .verifyIssueOnFile();
   }
+
+  @Test
+  void testFileWithTabsInMultilineStringIndentationShouldAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new TabulationCharacterCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendDecl("const")
+                .appendDecl(" Foo = '''")
+                .appendDecl("\t\tBar")
+                .appendDecl("\t\t''';"))
+        .verifyIssueOnFile();
+  }
 }