Exclude non-trivial inherited expressions in RedundantParentheses

Author: cirras

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Non-trivial `inherited` expressions are excluded in `RedundantParentheses`.
+
 ## [1.9.0] - 2024-09-03
 
 ### Added

delphi-checks/src/main/java/au/com/integradev/delphi/checks/RedundantParenthesesCheck.java

@@ -19,8 +19,10 @@
 package au.com.integradev.delphi.checks;
 
 import org.sonar.check.Rule;
+import org.sonar.plugins.communitydelphi.api.ast.ExpressionNode;
 import org.sonar.plugins.communitydelphi.api.ast.ParenthesizedExpressionNode;
 import org.sonar.plugins.communitydelphi.api.ast.PrimaryExpressionNode;
+import org.sonar.plugins.communitydelphi.api.ast.utils.ExpressionNodeUtils;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheck;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheckContext;
 import org.sonar.plugins.communitydelphi.api.reporting.QuickFix;
@@ -35,8 +37,7 @@ public class RedundantParenthesesCheck extends DelphiCheck {
   @Override
   public DelphiCheckContext visit(
       ParenthesizedExpressionNode expression, DelphiCheckContext context) {
-    if (expression.getExpression() instanceof ParenthesizedExpressionNode
-        || expression.getExpression() instanceof PrimaryExpressionNode) {
+    if (isRedundant(expression)) {
       context
           .newIssue()
           .onNode(expression.getChild(0))
@@ -50,4 +51,17 @@ public DelphiCheckContext visit(
     }
     return super.visit(expression, context);
   }
+
+  private static boolean isRedundant(ParenthesizedExpressionNode expression) {
+    ExpressionNode parenthesized = expression.getExpression();
+    if (parenthesized instanceof PrimaryExpressionNode) {
+      return !isNonTrivialInherited(parenthesized);
+    }
+    return parenthesized instanceof ParenthesizedExpressionNode;
+  }
+
+  private static boolean isNonTrivialInherited(ExpressionNode expression) {
+    return ExpressionNodeUtils.isInherited(expression)
+        && !ExpressionNodeUtils.isBareInherited(expression);
+  }
 }

delphi-checks/src/test/java/au/com/integradev/delphi/checks/RedundantParenthesesCheckTest.java

@@ -88,6 +88,19 @@ void testParenthesesOnUnaryExpressionShouldNotAddIssue() {
         .verifyNoIssues();
   }
 
+  @Test
+  void testParenthesesOnNonTrivialInheritedExpressionShouldAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new RedundantParenthesesCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendImpl("procedure Foo;")
+                .appendImpl("begin")
+                .appendImpl("  (inherited Bar);")
+                .appendImpl("end;"))
+        .verifyNoIssues();
+  }
+
   @Test
   void testParenthesesOnParenthesizedExpressionShouldAddIssue() {
     CheckVerifier.newVerifier()
@@ -121,4 +134,19 @@ void testParenthesesOnPrimaryExpressionShouldAddIssue() {
                 .appendImpl("end;"))
         .verifyIssues();
   }
+
+  @Test
+  void testParenthesesOnBareInheritedExpressionShouldAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new RedundantParenthesesCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendImpl("procedure Foo;")
+                .appendImpl("begin")
+                .appendImpl("  // Fix@[+2:2 to +2:3] <<>>")
+                .appendImpl("  // Fix@[+1:12 to +1:13] <<>>")
+                .appendImpl("  (inherited); // Noncompliant")
+                .appendImpl("end;"))
+        .verifyIssues();
+  }
 }