Remove NameOccurrence::isRoutineReference

Author: cirras

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/occurrence/NameOccurrenceImpl.java

@@ -32,7 +32,6 @@ public class NameOccurrenceImpl implements NameOccurrence {
   private NameDeclaration declaration;
   private String image;
   private boolean isExplicitInvocation;
-  private boolean isRoutineReference;
   private boolean isGeneric;
   private List<Type> typeParameters = Collections.emptyList();
 
@@ -80,15 +79,6 @@ public boolean isExplicitInvocation() {
     return isExplicitInvocation;
   }
 
-  public void setIsRoutineReference() {
-    this.isRoutineReference = true;
-  }
-
-  @Override
-  public boolean isRoutineReference() {
-    return isRoutineReference;
-  }
-
   public void setIsGeneric() {
     this.isGeneric = true;
   }
@@ -123,7 +113,6 @@ public boolean equals(Object o) {
     }
     NameOccurrenceImpl that = (NameOccurrenceImpl) o;
     return isExplicitInvocation == that.isExplicitInvocation
-        && isRoutineReference == that.isRoutineReference
         && isGeneric == that.isGeneric
         && location.equals(that.location)
         && Objects.equals(declaration, that.declaration)
@@ -133,13 +122,7 @@ public boolean equals(Object o) {
   @Override
   public int hashCode() {
     return Objects.hash(
-        location,
-        declaration,
-        image,
-        isExplicitInvocation,
-        isRoutineReference,
-        isGeneric,
-        typeParameters);
+        location, declaration, image, isExplicitInvocation, isGeneric, typeParameters);
   }
 
   @Override

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolver.java

@@ -1025,7 +1025,6 @@ void disambiguateRoutineReference(ProceduralType procedure) {
 
     if (bestDeclaration != null) {
       declarations.add(bestDeclaration);
-      Iterables.getLast(names).setIsRoutineReference();
     }
   }
 
@@ -1037,7 +1036,6 @@ void disambiguateAddressOfRoutineReference() {
     if (first != null) {
       declarations.clear();
       declarations.add(first);
-      Iterables.getLast(names).setIsRoutineReference();
     }
   }
 

delphi-frontend/src/main/java/org/sonar/plugins/communitydelphi/api/symbol/NameOccurrence.java

@@ -33,8 +33,6 @@ public interface NameOccurrence {
 
   boolean isExplicitInvocation();
 
-  boolean isRoutineReference();
-
   boolean isAttributeReference();
 
   boolean isGeneric();

delphi-frontend/src/test/java/au/com/integradev/delphi/symbol/occurrence/NameOccurrenceImplTest.java

@@ -30,18 +30,6 @@
 import org.sonar.plugins.communitydelphi.api.type.TypeFactory;
 
 class NameOccurrenceImplTest {
-  @Test
-  void testIsRoutineReference() {
-    SymbolicNode symbolicNode = SymbolicNode.imaginary("Foo", DelphiScope.unknownScope());
-    NameOccurrenceImpl occurrence = new NameOccurrenceImpl(symbolicNode);
-
-    assertThat(occurrence.isRoutineReference()).isFalse();
-
-    occurrence.setIsRoutineReference();
-
-    assertThat(occurrence.isRoutineReference()).isTrue();
-  }
-
   @Test
   void testIsGeneric() {
     SymbolicNode symbolicNode = SymbolicNode.imaginary("Foo", DelphiScope.unknownScope());
@@ -81,20 +69,16 @@ void testEquals() {
     assertThat(occurrenceA).isNotEqualTo(occurrenceD);
 
     NameOccurrenceImpl occurrenceE = new NameOccurrenceImpl(foo);
-    occurrenceE.setIsRoutineReference();
+    occurrenceE.setIsGeneric();
     assertThat(occurrenceA).isNotEqualTo(occurrenceE);
 
     NameOccurrenceImpl occurrenceF = new NameOccurrenceImpl(foo);
-    occurrenceF.setIsGeneric();
+    occurrenceF.setNameDeclaration(mock(NameDeclaration.class));
     assertThat(occurrenceA).isNotEqualTo(occurrenceF);
 
     NameOccurrenceImpl occurrenceG = new NameOccurrenceImpl(foo);
-    occurrenceG.setNameDeclaration(mock(NameDeclaration.class));
+    occurrenceG.setTypeArguments(List.of(TypeFactory.unknownType()));
     assertThat(occurrenceA).isNotEqualTo(occurrenceG);
-
-    NameOccurrenceImpl occurrenceI = new NameOccurrenceImpl(foo);
-    occurrenceI.setTypeArguments(List.of(TypeFactory.unknownType()));
-    assertThat(occurrenceA).isNotEqualTo(occurrenceI);
   }
 
   @Test