Improve type resolution for multidimensional constant array expressions

Author: cirras

CHANGELOG.md

@@ -63,6 +63,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Name resolution failures on invocations of methods with generic open array parameters.
 - Name resolution failures around `Create` calls on types with `constructor` constraints.
 - Name resolution failures on `read`, `write`, and `stored` specifiers of indexed properties.
+- Type resolution failures on array expressions nested within multidimensional constant arrays.
 - Incorrect file position calculation for multiline string tokens.
 - Analysis errors around `type of` type declarations.
 

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/ArrayExpressionNodeImpl.java

@@ -26,9 +26,12 @@
 import javax.annotation.Nonnull;
 import org.antlr.runtime.Token;
 import org.sonar.plugins.communitydelphi.api.ast.ArrayExpressionNode;
+import org.sonar.plugins.communitydelphi.api.ast.DelphiNode;
 import org.sonar.plugins.communitydelphi.api.ast.ExpressionNode;
 import org.sonar.plugins.communitydelphi.api.type.Type;
+import org.sonar.plugins.communitydelphi.api.type.Type.CollectionType;
 import org.sonar.plugins.communitydelphi.api.type.TypeFactory;
+import org.sonar.plugins.communitydelphi.api.type.Typed;
 
 public final class ArrayExpressionNodeImpl extends ExpressionNodeImpl
     implements ArrayExpressionNode {
@@ -65,11 +68,32 @@ public String getImage() {
   @Override
   @Nonnull
   protected Type createType() {
+    int nestingLevel = 0;
+    DelphiNode parent = this;
+    do {
+      ++nestingLevel;
+      parent = parent.getParent();
+    } while (parent instanceof ArrayExpressionNode);
+
     Type elementType = TypeFactory.unknownType();
-    List<ExpressionNode> elements = getElements();
-    if (!elements.isEmpty()) {
-      elementType = elements.get(0).getType();
+    if (parent instanceof Typed) {
+      elementType = ((Typed) parent).getType();
+      for (int i = 0; i < nestingLevel; ++i) {
+        if (!(elementType instanceof CollectionType)) {
+          elementType = TypeFactory.unknownType();
+          break;
+        }
+        elementType = ((CollectionType) elementType).elementType();
+      }
+    }
+
+    if (elementType.isUnknown()) {
+      List<ExpressionNode> elements = getElements();
+      if (!elements.isEmpty()) {
+        elementType = elements.get(0).getType();
+      }
     }
+
     return ((TypeFactoryImpl) getTypeFactory()).array(null, elementType, Set.of(ArrayOption.FIXED));
   }
 }