Include property expressions in ObjectPassedAsInterface

Author: cirras

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Exclude common non-ref-counted interface implementations by default in `ObjectPassedAsInterface`.
+- Handle property references in `ObjectPassedAsInterface` (in addition to variables/fields).
 
 ### Fixed
 

delphi-checks/src/main/java/au/com/integradev/delphi/checks/ObjectPassedAsInterfaceCheck.java

@@ -32,9 +32,11 @@
 import org.sonar.plugins.communitydelphi.api.ast.PrimaryExpressionNode;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheck;
 import org.sonar.plugins.communitydelphi.api.check.DelphiCheckContext;
+import org.sonar.plugins.communitydelphi.api.symbol.declaration.PropertyNameDeclaration;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.RoutineNameDeclaration;
 import org.sonar.plugins.communitydelphi.api.symbol.declaration.VariableNameDeclaration;
 import org.sonar.plugins.communitydelphi.api.type.Type;
+import org.sonar.plugins.communitydelphi.api.type.Typed;
 
 @Rule(key = "ObjectPassedAsInterface")
 public class ObjectPassedAsInterfaceCheck extends DelphiCheck {
@@ -91,11 +93,12 @@ private boolean isObjectReferenceExpression(ExpressionNode expression) {
     }
 
     var declaration = ((NameReferenceNode) maybeName).getLastName().getNameDeclaration();
-    if (!(declaration instanceof VariableNameDeclaration)) {
+    if (!(declaration instanceof VariableNameDeclaration
+        || declaration instanceof PropertyNameDeclaration)) {
       return false;
     }
 
-    Type type = ((VariableNameDeclaration) declaration).getType();
+    Type type = ((Typed) declaration).getType();
 
     return type.isClass()
         && excludedTypesList.stream().noneMatch(e -> type.is(e) || type.isDescendantOf(e));

delphi-checks/src/test/java/au/com/integradev/delphi/checks/ObjectPassedAsInterfaceCheckTest.java

@@ -67,6 +67,31 @@ void testObjectPassedAsInterfaceShouldAddIssue() {
         .verifyIssues();
   }
 
+  @Test
+  void testQualifiedObjectPassedAsInterfaceShouldAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new ObjectPassedAsInterfaceCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendDecl("type")
+                .appendDecl("  TFoo = class(TInterfacedObject, IInterface)")
+                .appendDecl("  end;")
+                .appendDecl("  IBar = interface")
+                .appendDecl("    property Foo: TFoo;")
+                .appendDecl("  end;")
+                .appendDecl("  TBar = class(TInterfacedObject, IBar)")
+                .appendDecl("  end;")
+                .appendDecl("procedure DoThing(Obj: IInterface);")
+                .appendImpl("procedure Test;")
+                .appendImpl("var")
+                .appendImpl("  Intf: IBar;")
+                .appendImpl("begin")
+                .appendImpl("  Intf := TBar.Create;")
+                .appendImpl("  DoThing(Intf.Foo); // Noncompliant")
+                .appendImpl("end;"))
+        .verifyIssues();
+  }
+
   @Test
   void testInterfacePassedAsInterfaceShouldNotAddIssue() {
     CheckVerifier.newVerifier()