Prevent double-resolution of property specifiers

Property specifiers `read`/`write`/`implements`/`stored` were being
resolved twice, which was unnecessary because they should be resolved as
part of the top-level resolution of the `PropertyNode`.

In a funny twist, it turns out we were actually relying on that second
visit to resolve non-invocable expressions in `read`/`write`/`stored`
specifiers. This is now handled properly in the top-level resolve.

Author: cirras

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/visitors/SymbolTableVisitor.java

@@ -102,7 +102,11 @@
 import org.sonar.plugins.communitydelphi.api.ast.PointerTypeNode;
 import org.sonar.plugins.communitydelphi.api.ast.PrimaryExpressionNode;
 import org.sonar.plugins.communitydelphi.api.ast.ProcedureTypeHeadingNode;
+import org.sonar.plugins.communitydelphi.api.ast.PropertyImplementsSpecifierNode;
 import org.sonar.plugins.communitydelphi.api.ast.PropertyNode;
+import org.sonar.plugins.communitydelphi.api.ast.PropertyReadSpecifierNode;
+import org.sonar.plugins.communitydelphi.api.ast.PropertyStoredSpecifierNode;
+import org.sonar.plugins.communitydelphi.api.ast.PropertyWriteSpecifierNode;
 import org.sonar.plugins.communitydelphi.api.ast.RecordTypeNode;
 import org.sonar.plugins.communitydelphi.api.ast.RecordVariantTagNode;
 import org.sonar.plugins.communitydelphi.api.ast.RepeatStatementNode;
@@ -517,6 +521,30 @@ public Data visit(PropertyNode node, Data data) {
     return createDeclarationScope(node, data);
   }
 
+  @Override
+  public Data visit(PropertyReadSpecifierNode node, Data data) {
+    // Already resolved by the PropertyNode visit.
+    return data;
+  }
+
+  @Override
+  public Data visit(PropertyWriteSpecifierNode node, Data data) {
+    // Already resolved by the PropertyNode visit.
+    return data;
+  }
+
+  @Override
+  public Data visit(PropertyImplementsSpecifierNode node, Data data) {
+    // Already resolved by the PropertyNode visit.
+    return data;
+  }
+
+  @Override
+  public Data visit(PropertyStoredSpecifierNode node, Data data) {
+    // Already resolved by the PropertyNode visit.
+    return data;
+  }
+
   @Nullable
   private static PropertyNameDeclaration findConcretePropertyDeclaration(PropertyNode property) {
     if (!property.getType().isUnknown()) {

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolutionHelper.java

@@ -255,15 +255,19 @@ public void resolve(PropertyNode property) {
     if (read != null) {
       NameResolver readResolver = createNameResolver();
       readResolver.readPrimaryExpression(read.getExpression());
-      readResolver.disambiguateParameters(getGetterParameterTypes(property));
+      if (isResolvingRoutine(readResolver)) {
+        readResolver.disambiguateParameters(getGetterParameterTypes(property));
+      }
       readResolver.addToSymbolTable();
     }
 
     PropertyWriteSpecifierNode write = property.getWriteSpecifier();
     if (write != null) {
       NameResolver writeResolver = createNameResolver();
       writeResolver.readPrimaryExpression(write.getExpression());
-      writeResolver.disambiguateParameters(getSetterParameterTypes(property));
+      if (isResolvingRoutine(writeResolver)) {
+        writeResolver.disambiguateParameters(getSetterParameterTypes(property));
+      }
       writeResolver.addToSymbolTable();
     }
 
@@ -276,11 +280,17 @@ public void resolve(PropertyNode property) {
     if (stored != null && stored.getExpression() instanceof PrimaryExpressionNode) {
       NameResolver storedResolver = createNameResolver();
       storedResolver.readPrimaryExpression((PrimaryExpressionNode) stored.getExpression());
-      storedResolver.disambiguateParameters(getStorageParameterTypes(property));
+      if (isResolvingRoutine(storedResolver)) {
+        storedResolver.disambiguateParameters(getStorageParameterTypes(property));
+      }
       storedResolver.addToSymbolTable();
     }
   }
 
+  private static boolean isResolvingRoutine(NameResolver resolver) {
+    return resolver.getDeclarations().stream().anyMatch(RoutineNameDeclaration.class::isInstance);
+  }
+
   private List<Type> getGetterParameterTypes(PropertyNode property) {
     if (property.getIndexSpecifier() == null) {
       return property.getParameterTypes();