Improve modeling of finally-except nesting in ControlFlowGraphs

Author: jgardn3r

delphi-frontend/src/main/java/au/com/integradev/delphi/cfg/ControlFlowGraphVisitor.java

@@ -524,6 +524,9 @@ public ControlFlowGraphBuilder visit(TryStatementNode node, ControlFlowGraphBuil
 
   private ControlFlowGraphBuilder buildTryFinally(
       TryStatementNode node, ControlFlowGraphBuilder builder) {
+    // to ensure after a `finally` exceptional paths still exist
+    handleExceptionalPaths(builder);
+
     builder.addBlockBeforeCurrent();
     // Finally
     FinallyBlockNode finallyNode = node.getFinallyBlock();

delphi-frontend/src/test/java/au/com/integradev/delphi/cfg/ControlFlowGraphTest.java

@@ -1142,10 +1142,12 @@ void testNestedTryFinallyExcept() {
                 "procedure Baz; begin end")),
         "try try Foo finally Bar end except on E: Exception do Baz end;",
         checker(
-            block(element(TryStatementNode.class)).succeedsTo(4),
-            block(element(TryStatementNode.class)).succeedsTo(3),
-            block(element(NameReferenceNode.class, "Foo")).succeedsToWithExceptions(2, 2),
-            block(element(NameReferenceNode.class, "Bar")).succeedsToWithExceptions(0, 0, 1),
+            block(element(TryStatementNode.class)).succeedsTo(6),
+            block(element(TryStatementNode.class)).succeedsTo(5),
+            block(element(NameReferenceNode.class, "Foo")).succeedsToWithExceptions(4, 4),
+            block(element(NameReferenceNode.class, "Bar")).succeedsToWithExceptions(3, 0, 1),
+            block().succeedsToWithExit(2, 0),
+            block().succeedsToWithExceptions(0, 0, 1),
             block(element(NameDeclarationNode.class, "E"), element(NameReferenceNode.class, "Baz"))
                 .succeedsTo(0)));
   }