Fix type resolution failures on property/routine attribute lists

Specifically...
- `PropertyNameDeclaration::attributeTypes` were always unknown.
- `RoutineNameDeclaration::attributeTypes` were unknown for
   implementation-local routines.

Author: cirras

CHANGELOG.md

@@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Name resolution failures on generic routine invocations where later type parameters are constrained by earlier type parameters.
+- Type resolution failures on property attribute lists.
+- Type resolution failures on implementation-local routine attribute lists.
 - Type resolution failures on `as` casts where the type is returned from a routine invocation.
 - Inaccurate type resolution when calling a constructor on a class reference type.
 - Grammar ambiguity causing attributes to be misinterpreted as interface GUIDs.

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/visitors/SymbolTableVisitor.java

@@ -63,6 +63,7 @@
 import javax.annotation.Nullable;
 import org.sonar.plugins.communitydelphi.api.ast.AnonymousMethodNode;
 import org.sonar.plugins.communitydelphi.api.ast.ArrayConstructorNode;
+import org.sonar.plugins.communitydelphi.api.ast.AttributeListNode;
 import org.sonar.plugins.communitydelphi.api.ast.AttributeNode;
 import org.sonar.plugins.communitydelphi.api.ast.CaseItemStatementNode;
 import org.sonar.plugins.communitydelphi.api.ast.CaseStatementNode;
@@ -111,6 +112,7 @@
 import org.sonar.plugins.communitydelphi.api.ast.RepeatStatementNode;
 import org.sonar.plugins.communitydelphi.api.ast.RoutineBodyNode;
 import org.sonar.plugins.communitydelphi.api.ast.RoutineDeclarationNode;
+import org.sonar.plugins.communitydelphi.api.ast.RoutineHeadingNode;
 import org.sonar.plugins.communitydelphi.api.ast.RoutineImplementationNode;
 import org.sonar.plugins.communitydelphi.api.ast.RoutineNameNode;
 import org.sonar.plugins.communitydelphi.api.ast.RoutineNode;
@@ -825,6 +827,23 @@ public Data visit(PrimaryExpressionNode node, Data data) {
     return data;
   }
 
+  @Override
+  public Data visit(AttributeListNode node, Data data) {
+    DelphiNode parent = node.getParent();
+
+    if (parent instanceof PropertyNode) {
+      // Already resolved by the PropertyNode visit.
+      return data;
+    }
+
+    if (parent instanceof RoutineHeadingNode) {
+      // Already resolved by the RoutineNode visit.
+      return data;
+    }
+
+    return DelphiParserVisitor.super.visit(node, data);
+  }
+
   @Override
   public Data visit(AttributeNode node, Data data) {
     data.nameResolutionHelper.resolve(node);

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolutionHelper.java

@@ -167,6 +167,12 @@ public void resolve(NameReferenceNode reference) {
     resolver.addToSymbolTable();
   }
 
+  private void resolve(@Nullable AttributeListNode attributeList) {
+    if (attributeList != null) {
+      attributeList.getAttributes().forEach(this::resolve);
+    }
+  }
+
   public void resolve(AttributeNode attribute) {
     NameResolver resolver = createNameResolver();
     resolver.readAttribute(attribute);
@@ -255,6 +261,7 @@ public void resolve(MethodResolutionClauseNode resolutionClause) {
   }
 
   public void resolve(PropertyNode property) {
+    resolve(property.getAttributeList());
     resolve(property.getParameterListNode());
 
     TypeNode type = property.getTypeNode();
@@ -427,6 +434,7 @@ private static boolean isBareInterfaceRoutineReference(
   }
 
   private void resolveRoutine(RoutineNode routine) {
+    resolve(routine.getRoutineHeading().getAttributeList());
     SearchMode previousSearchMode = searchMode;
     try {
       searchMode = SearchMode.ROUTINE_HEADING;