Implement support for assembly attributes

Author: cirras

CHANGELOG.md

@@ -12,12 +12,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Support for multiline string literals within compiler directives.
 - Support for the `TEXTBLOCK` directive.
 - Support for named arguments.
+- Support for `assembly` attributes.
 - **API:** `CompilerDirectiveParser` can now return a new `TextBlockDirective` type.
 - **API:** `CheckVerifier::withCompilerVersion` method.
 - **API:** `CheckVerifier::withToolchain` method.
 - **API:** `DelphiTokenType.ARGUMENT` token type.
+- **API:** `DelphiTokenType.ASSEMBLY` token type.
 - **API:** `ArgumentNode` node type.
 - **API:** `ArgumentListNode::getArgumentNodes` method.
+- **API:** `AttributeNode::isAssembly` method.
 
 ### Changed
 

delphi-frontend/src/main/antlr3/au/com/integradev/delphi/antlr/Delphi.g

@@ -265,7 +265,7 @@ library                      : libraryHead usesFileClause? programBody '.'
                              ;
 libraryHead                  : LIBRARY<LibraryDeclarationNodeImpl>^ qualifiedNameDeclaration (portabilityDirective!)* ';'!
                              ;
-package_                     : packageHead requiresClause? containsClause END '.'
+package_                     : packageHead requiresClause? containsClause? attributeList* END '.'
                              ;
 packageHead                  : PACKAGE<PackageDeclarationNodeImpl>^ qualifiedNameDeclaration ';'!
                              ;
@@ -327,12 +327,14 @@ declSection                  : labelDeclSection
                              | varSection
                              | routineImplementation
                              | exportsSection
+                             | attributeList
                              ;
 interfaceDecl                : constSection
                              | typeSection
                              | varSection
                              | exportsSection
                              | routineInterface
+                             | attributeList
                              ;
 labelDeclSection             : LABEL (label (','!)?)+ ';'
                              ;
@@ -687,8 +689,8 @@ attributeList                : attributeGroup+
 attributeGroup               : lbrack (attribute ','?)+ rbrack
                              -> ^(TkAttributeGroup<AttributeGroupNodeImpl> attribute+)
                              ;
-attribute                    : nameReference argumentList?
-                             -> ^(TkAttribute<AttributeNodeImpl> nameReference argumentList?)
+attribute                    : (ASSEMBLY ':')? nameReference argumentList? (':' nameReference argumentList?)*
+                             -> ^(TkAttribute<AttributeNodeImpl> ASSEMBLY? nameReference argumentList? (':' nameReference argumentList?)*)
                              ;
 
 //----------------------------------------------------------------------------
@@ -979,15 +981,15 @@ dispIDDirective              : DISPID expression
 ident                        : TkIdentifier
                              | keywordsUsedAsNames -> ^({changeTokenType(TkIdentifier)})
                              ;
-keywordsUsedAsNames          : (ABSOLUTE | ABSTRACT | ALIGN | ASSEMBLER | AT | AUTOMATED | CDECL)
+keywordsUsedAsNames          : (ABSOLUTE | ABSTRACT | ALIGN | ASSEMBLER | ASSEMBLY | AT | AUTOMATED | CDECL)
                              | (CONTAINS | DEFAULT | DELAYED | DEPRECATED | DISPID | DYNAMIC | EXPERIMENTAL | EXPORT)
                              | (EXTERNAL | FAR | FINAL | FORWARD | HELPER | IMPLEMENTS | INDEX | LOCAL | MESSAGE | NAME)
                              | (NEAR | NODEFAULT | ON | OPERATOR | OUT | OVERLOAD | OVERRIDE | PACKAGE | PASCAL | PLATFORM)
                              | (PRIVATE | PROTECTED | PUBLIC | PUBLISHED | READ | READONLY | REFERENCE | REGISTER | REINTRODUCE)
                              | (REQUIRES | RESIDENT | SAFECALL | SEALED | STATIC | STDCALL | STORED | STRICT | UNSAFE)
                              | (VARARGS | VIRTUAL | WRITE | WRITEONLY)
                              ;
-keywords                     : (ABSOLUTE | ABSTRACT | AND | ALIGN | ARRAY | AS | ASM | ASSEMBLER)
+keywords                     : (ABSOLUTE | ABSTRACT | AND | ALIGN | ARRAY | AS | ASM | ASSEMBLER | ASSEMBLY)
                              | (AT | AUTOMATED | BEGIN | CASE | CDECL | CLASS | CONST | CONSTRUCTOR | CONTAINS| DEFAULT)
                              | (DELAYED | DEPRECATED | DESTRUCTOR | DISPID | DISPINTERFACE | DIV | DO | DOWNTO | DYNAMIC)
                              | (ELSE | END | EXCEPT | EXPERIMENTAL | EXPORT | EXPORTS | EXTERNAL | FAR | FILE | FINAL)
@@ -1052,6 +1054,7 @@ ARRAY             : A R R A Y                   ;
 AS                : A S                         ;
 ASM               : A S M { asmMode = true; }   ;
 ASSEMBLER         : A S S E M B L E R           ;
+ASSEMBLY          : A S S E M B L Y             ;
 AT                : A T                         ;
 AUTOMATED         : A U T O M A T E D           ;
 BEGIN             : B E G I N                   ;

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/AttributeNodeImpl.java

@@ -23,8 +23,10 @@
 import org.antlr.runtime.Token;
 import org.sonar.plugins.communitydelphi.api.ast.ArgumentListNode;
 import org.sonar.plugins.communitydelphi.api.ast.AttributeNode;
+import org.sonar.plugins.communitydelphi.api.ast.DelphiNode;
 import org.sonar.plugins.communitydelphi.api.ast.NameReferenceNode;
 import org.sonar.plugins.communitydelphi.api.symbol.NameOccurrence;
+import org.sonar.plugins.communitydelphi.api.token.DelphiTokenType;
 
 public final class AttributeNodeImpl extends DelphiNodeImpl implements AttributeNode {
   public AttributeNodeImpl(Token token) {
@@ -35,9 +37,14 @@ public AttributeNodeImpl(int tokenType) {
     super(tokenType);
   }
 
+  @Override
+  public boolean isAssembly() {
+    return getChild(0).getTokenType() == DelphiTokenType.ASSEMBLY;
+  }
+
   @Override
   public NameReferenceNode getNameReference() {
-    return (NameReferenceNode) getChild(0);
+    return (NameReferenceNode) getChild(isAssembly() ? 1 : 0);
   }
 
   @Override
@@ -56,7 +63,11 @@ public NameOccurrence getConstructorNameOccurrence() {
 
   @Override
   public ArgumentListNode getArgumentList() {
-    return (ArgumentListNode) getChild(1);
+    DelphiNode node = getChild(isAssembly() ? 2 : 1);
+    if (node instanceof ArgumentListNode) {
+      return (ArgumentListNode) node;
+    }
+    return null;
   }
 
   @Override

delphi-frontend/src/main/java/org/sonar/plugins/communitydelphi/api/ast/AttributeNode.java

@@ -22,6 +22,16 @@
 import org.sonar.plugins.communitydelphi.api.symbol.NameOccurrence;
 
 public interface AttributeNode extends DelphiNode {
+
+  /**
+   * Returns whether this is an {@code assembly} attribute.
+   *
+   * @return true if this is an {@code assembly} attribute
+   * @see <a href="https://learn.microsoft.com/en-us/dotnet/standard/assembly/set-attributes">Set
+   *     assembly attributes in code</a>
+   */
+  boolean isAssembly();
+
   NameReferenceNode getNameReference();
 
   @Nullable

delphi-frontend/src/test/java/au/com/integradev/delphi/antlr/GrammarTest.java

@@ -85,6 +85,26 @@ void testEmptyBeginStatement() {
     assertParsed("EmptyProcs.pas");
   }
 
+  @Test
+  void testAttributesUnit() {
+    assertParsed("AttributesUnit.pas");
+  }
+
+  @Test
+  void testAttributesProgram() {
+    assertParsed("AttributesProgram.dpr");
+  }
+
+  @Test
+  void testAttributesLibrary() {
+    assertParsed("AttributesLibrary.dpr");
+  }
+
+  @Test
+  void testAttributesPackage() {
+    assertParsed("AttributesPackage.dpk");
+  }
+
   @Test
   void testParseMultipleAttributes() {
     assertParsed("MultipleAttributes.pas");

delphi-frontend/src/test/resources/au/com/integradev/delphi/grammar/AttributesLibrary.dpr

@@ -0,0 +1,27 @@
+library AttributesLibrary;
+
+[xyz]
+[assembly: xyz]
+
+type
+  [xyz]
+  [assembly: xyz]
+  [xyz]
+  TMyType = Integer;
+
+[xyz]
+procedure Foo;
+[xyz]
+var
+  [xyz]
+  Bar: Integer;
+begin
+
+end;
+
+[xyz]
+[assembly: xyz]
+
+begin
+
+end.

delphi-frontend/src/test/resources/au/com/integradev/delphi/grammar/AttributesPackage.dpk

@@ -0,0 +1,12 @@
+package AttributesPackage;
+
+requires
+  Foo,
+  Bar;
+
+contains
+  AmpersandNumericLiterals in 'AmpersandNumericLiterals.pas';
+
+[assembly: xyz]
+
+end.

delphi-frontend/src/test/resources/au/com/integradev/delphi/grammar/AttributesProgram.dpr

@@ -0,0 +1,27 @@
+program AttributesProgram;
+
+[xyz]
+[assembly: xyz]
+
+type
+  [xyz]
+  [assembly: xyz]
+  [xyz]
+  TMyType = Integer;
+
+[xyz]
+procedure Foo;
+[xyz]
+var
+  [xyz]
+  Bar: Integer;
+begin
+
+end;
+
+[xyz]
+[assembly: xyz]
+
+begin
+
+end.

delphi-frontend/src/test/resources/au/com/integradev/delphi/grammar/AttributesUnit.pas

@@ -0,0 +1,32 @@
+unit AttributesUnit;
+
+interface
+
+[xyz]
+[assembly: xyz]
+
+type
+  [xyz]
+  [assembly: xyz]
+  [xyz]
+  TMyType = Integer;
+
+[xyz]
+[assembly: xyz]
+
+implementation
+
+[xyz]
+procedure Foo;
+[xyz]
+var
+  [xyz]
+  Bar: Integer;
+begin
+
+end;
+
+[xyz]
+[assembly: xyz]
+
+end.