Commit ca78a54
committed
Fix bug where attribute names unsuffixed themselves and shadowed things
Guava's multimaps return mutable collections from `get`, and
modifications to those collections are reflected in the multimap.
In this case, the scenario was:
- you're trying to find the declaration with attribute reference `Foo`
- you search for `Foo` and get an empty collection back
- you search for `FooAttribute` and add the results to that collection
- the scope now has a declaration called `Foo` mapping to `FooAttribute`
tl;dr mutability is evil.1 parent 6870b14 commit ca78a54
File tree
1 file changed
+1
-0
lines changed- delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/scope
1 file changed
+1
-0
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
318 | 318 | | |
319 | 319 | | |
320 | 320 | | |
| 321 | + | |
321 | 322 | | |
322 | 323 | | |
323 | 324 | | |
| |||
0 commit comments