Downgrade duplicate unit import error to warning

Author: fourls

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - The `Copy` intrinsic inferred an incorrect return type for `PChar`, `PAnsiChar`, and variants.
 - The `Concat` intrinsic inferred an incorrect return type for single-character string literals.
 - Ideographic space (U+3000) was erroneously accepted as a valid identifier character.
+- Duplicate imports in a `requires` clause now log a warning instead of throwing an exception.
 
 ## [1.1.0] - 2024-01-02
 

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/scope/FileScopeImpl.java

@@ -32,6 +32,8 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.sonar.plugins.communitydelphi.api.ast.ArrayAccessorNode;
 import org.sonar.plugins.communitydelphi.api.ast.NameDeclarationNode;
 import org.sonar.plugins.communitydelphi.api.ast.NameReferenceNode;
@@ -48,6 +50,7 @@
 import org.sonar.plugins.communitydelphi.api.type.Type.HelperType;
 
 public abstract class FileScopeImpl extends DelphiScopeImpl implements FileScope {
+  private static final Logger LOG = LoggerFactory.getLogger(FileScopeImpl.class);
   private final String name;
   private final Deque<FileScope> imports = new ArrayDeque<>();
   private Map<Integer, DelphiScope> registeredScopes = new HashMap<>();
@@ -107,7 +110,17 @@ public void addDeclaration(NameDeclaration declaration) {
         imports.addFirst(scope);
       }
     }
-    super.addDeclaration(declaration);
+
+    try {
+      super.addDeclaration(declaration);
+    } catch (DuplicatedDeclarationException e) {
+      if (declaration instanceof UnitImportNameDeclaration) {
+        // 'requires' clauses can have multiple occurrences of the same unit import
+        LOG.warn("Duplicate unit import found: {}", e.getMessage());
+      } else {
+        throw e;
+      }
+    }
   }
 
   @Override