Improve handling of complex expressions in ObjectPassedAsInterface

Author: cirras

delphi-checks/src/main/java/au/com/integradev/delphi/checks/ObjectPassedAsInterfaceCheck.java

@@ -19,6 +19,7 @@
 package au.com.integradev.delphi.checks;
 
 import com.google.common.base.Splitter;
+import com.google.common.collect.Iterables;
 import java.util.Collections;
 import java.util.List;
 import java.util.Set;
@@ -87,7 +88,7 @@ private boolean isObjectReferenceExpression(ExpressionNode expression) {
       return false;
     }
 
-    var maybeName = expression.getChild(0);
+    var maybeName = Iterables.getLast(expression.getChildren());
     if (!(maybeName instanceof NameReferenceNode)) {
       return false;
     }

delphi-checks/src/test/java/au/com/integradev/delphi/checks/ObjectPassedAsInterfaceCheckTest.java

@@ -92,6 +92,31 @@ void testQualifiedObjectPassedAsInterfaceShouldAddIssue() {
         .verifyIssues();
   }
 
+  @Test
+  void testComplexQualifiedObjectPassedAsInterfaceShouldAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new ObjectPassedAsInterfaceCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendDecl("type")
+                .appendDecl("  TFoo = class(TInterfacedObject, IInterface)")
+                .appendDecl("  end;")
+                .appendDecl("  IBar = interface")
+                .appendDecl("    property Foo: TFoo;")
+                .appendDecl("  end;")
+                .appendDecl("  TBar = class(TInterfacedObject, IBar)")
+                .appendDecl("  end;")
+                .appendDecl("procedure DoThing(Obj: IInterface);")
+                .appendImpl("procedure Test;")
+                .appendImpl("var")
+                .appendImpl("  Intfs: TArray<IBar>;")
+                .appendImpl("begin")
+                .appendImpl("  Intfs := [TBar.Create];")
+                .appendImpl("  DoThing(Intfs[0].Foo); // Noncompliant")
+                .appendImpl("end;"))
+        .verifyIssues();
+  }
+
   @Test
   void testInterfacePassedAsInterfaceShouldNotAddIssue() {
     CheckVerifier.newVerifier()
@@ -130,6 +155,27 @@ void testQualifiedInterfacePassedAsInterfaceShouldNotAddIssue() {
         .verifyNoIssues();
   }
 
+  @Test
+  void testComplexQualifiedInterfacePassedAsInterfaceShouldNotAddIssue() {
+    CheckVerifier.newVerifier()
+        .withCheck(new ObjectPassedAsInterfaceCheck())
+        .onFile(
+            new DelphiTestUnitBuilder()
+                .appendDecl("type")
+                .appendDecl("  TFoo = class")
+                .appendDecl("    property Intf: IInterface;")
+                .appendDecl("  end;")
+                .appendDecl("procedure DoThing(Intf: IInterface);")
+                .appendImpl("procedure Test;")
+                .appendImpl("var")
+                .appendImpl("  Foos: TArray<TFoo>;")
+                .appendImpl("begin")
+                .appendImpl("  Foos := [TFoo.Create];")
+                .appendImpl("  DoThing(Foos[0].Intf);")
+                .appendImpl("end;"))
+        .verifyNoIssues();
+  }
+
   @Test
   void testObjectCastToInterfaceShouldNotAddIssue() {
     CheckVerifier.newVerifier()