Handle aliased imports in FullyQualifiedImport
#294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneduffield
requested changes
Sep 29, 2024
delphi-checks/src/test/java/au/com/integradev/delphi/checks/FullyQualifiedImportCheckTest.java
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/FullyQualifiedImportCheck.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
fully_qualified_rule_unit_aliases
branch
from
c173d00 to
342eceb
Compare
cirras
force-pushed
the
fully_qualified_rule_unit_aliases
branch
from
342eceb to
fb63fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
FullyQualifiedImportwhere unit aliases weren't considered, causing false positives on aliased imports.