Fix return types for Length/ High/ Low on open/dynamic arrays
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
approved these changes
Nov 12, 2024
...-frontend/src/test/java/au/com/integradev/delphi/type/intrinsic/IntrinsicReturnTypeTest.java
Outdated
Show resolved
Hide resolved
fourls
requested changes
Nov 12, 2024
cirras
force-pushed
the
array_size_types
branch
from
c23dba1 to
6b1e0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the return types for the
Length,High, andLowintrinsics more accurate.The new rules are:
Integeron 32-bit on all compiler versionsNativeInton 64-bit on all compiler versionsIntegeron 64-bit on all compiler versions prior to 36.0NativeInton 64-bit on all compiler versions from 36.0Fixes #296.