Detect trailing whitespace within comments in TrailingWhitespace
#349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
force-pushed
the
trailing_whitespace_in_comments
branch
from
8af4b4a to
ce01c3a
Compare
fourls
requested changes
Mar 27, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
This was a sneaky one! I have a few minor comments.
delphi-checks/src/main/java/au/com/integradev/delphi/checks/TrailingWhitespaceCheck.java
Outdated
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/TrailingWhitespaceCheck.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
trailing_whitespace_in_comments
branch
from
ce01c3a to
5ddbaa8
Compare
cirras
force-pushed
the
trailing_whitespace_in_comments
branch
from
5ddbaa8 to
8fd62fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
TrailingWhitespaceto detect trailing whitespace within comments.An incidental change is that we're now also detecting whitespace more accurately by matching characters in range
0x00-0x20. This matches the compiler's behavior.