Skip to content

Conversation

@fourls
Copy link
Collaborator

@fourls fourls commented Jul 25, 2025

Fixes #74.

@fourls fourls requested a review from cirras July 25, 2025 01:26
@fourls fourls force-pushed the default-param-count branch from f60b742 to 2995c57 Compare July 28, 2025 06:41
@fourls fourls requested a review from cirras July 28, 2025 06:42
@fourls fourls force-pushed the default-param-count branch from 2995c57 to 59cdfca Compare July 29, 2025 06:01
Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need CHANGELOG entries for the new rule and the changes to TooManyParameters.

@fourls fourls force-pushed the default-param-count branch from 59cdfca to 3ff8968 Compare July 30, 2025 02:10
@fourls fourls requested a review from cirras July 30, 2025 02:10
cirras
cirras previously approved these changes Jul 30, 2025
Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a rebase.

@fourls fourls force-pushed the default-param-count branch from 3ff8968 to 286a382 Compare July 30, 2025 03:08
@fourls fourls requested a review from cirras July 30, 2025 03:08
@cirras cirras merged commit 574b473 into master Jul 30, 2025
4 checks passed
@cirras cirras deleted the default-param-count branch October 30, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New rule: Methods should not have too many default parameters

3 participants