fix: github_repository_collaborators - mark invitation_ids as changed when new user invited (#1825)

* fix: mark invitation_ids as changed if new user is invited

* fix: documentation

---------

Co-authored-by: Keegan Campbell <[email protected]>

Author: Jacob Sifuentes

github/resource_github_repository_collaborators.go

@@ -8,6 +8,7 @@ import (
 	"strconv"
 
 	"github.com/google/go-github/v53/github"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 )
 
@@ -75,6 +76,14 @@ func resourceGithubRepositoryCollaborators() *schema.Resource {
 				Computed: true,
 			},
 		},
+
+		CustomizeDiff: customdiff.Sequence(
+			// If there was a new user added to the list of collaborators,
+			// it's possible a new invitation id will be created in GitHub.
+			customdiff.ComputedIf("invitation_ids", func(d *schema.ResourceDiff, meta interface{}) bool {
+				return d.HasChange("user")
+			}),
+		),
 	}
 }
 

website/docs/d/organization_external_identities.markdown

@@ -43,8 +43,8 @@ If a user is managed by SAML, the `saml_identity` object will contain:
 
 If a user is managed by SCIM, the `scim_identity` object will contain:
 
-- `scim_username` - The member's SCIM Username. (will be empty string if user is
-  not managed by SCIM)
-- `scim_groups` - The member's SCIM Groups
-- `scim_family_name` - The member's SCIM Family Name
-- `scim_given_name` - The member's SCIM Given Name
+- `username` - The member's SCIM Username. (will be empty string if user is not
+  managed by SCIM)
+- `groups` - The member's SCIM Groups
+- `family_name` - The member's SCIM Family Name
+- `given_name` - The member's SCIM Given Name