[BUG]: github_repository_collaborators shows the same user to be removed and added

[PaulRudin]

Expected Behavior

The plan for github_repository_collaborators shows the same user to be both removed and added: (I redacted the username)

Terraform will perform the following actions:

  # github_repository_collaborators.foo will be updated in-place
  ~ resource "github_repository_collaborators" "foo" {
        id             = "foo"
      - user {
          - permission = "pull" -> null
          - username   = "xxx" -> null
        }
      + user {
          + permission = "pull"
          + username   = "xxx"
        }

        # (1 unchanged block hidden)
    }

I expect that this shouldn't show any change for the user xxx

Actual Behavior

I see a removal and addition.

Terraform Version

$ terraform -v
Terraform v1.6.5
on linux_amd64

• provider registry.terraform.io/integrations/github v5.42.0

Affected Resource(s)

github_repository_collaborators

Terraform Configuration Files

No response

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[PaulRudin]

Just to add to this. When applying in this state I just had a problem in that, the provider first deleted the user, and then gave an error with a 404 when (presumbly) trying to add the user back. I had to re-invite the user to the repo.

[PaulRudin]

Possibly this this is something to do with accepting invitations... not sure.

[anttijman]

I have the same issue with this resource. Did you manage to work-around it? @PaulRudin

[glowack2]

I have noticed this issue when the case of the username doesn't match. For example, my username is glowack2 but if I put it in the .tf as GLOWACK2, it will always plan as a change to remove the lowercase version and add the uppercase. The fix is to have the username in the .tf exactly match the case of the actual username. This also affects github_team_members as noted in #1968 .

The preferred behavior would be for this to just be case insensitive.

[github-actions]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!