Skip to content

[FEAT]: Bypass preemptive rate limit check by go-github #2709

@kishaningithub

Description

@kishaningithub

Describe the need

The go-github library performs a preemptive rate limit check and prevents requests from happening when rate limit conditions are met and this provider in its transport logic performs a retry during rate limit scenario as well.

In a highly concurrent scenario where multiple terrafom plans are running in CI using the same github token the rate limit of 5000 per hour per user gets exhaused very fast and due to the premptive check some of the requests fail and some wait till the hour (rate limit rest time) has passed.

Proposal

Toggle off bypassRateLimitCheck context variable when passing in context to go-github library and make the rate limit logic at the transport layer of this provider be the only logic that is present

SDK Version

No response

API Version

No response

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: FeatureNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions