Skip to content

[MAINT]: Remove read call from create/update #2892

@stevehipwell

Description

@stevehipwell

Describe the need

This provider make heavy use of calling the read function instead of duplicating logic in the create/update functions; while this may look clean and DRY it has a significant impact. Firstly it means that changes generally use twice as many API calls to make as they should (or more in cases where a single resource is mapped to multiple API calls); which is impactful given the low API rate limits imposed by GitHub. Secondly it means that systems which don't have strict read after write guarantees may be returning incorrect values to be stored in the state.

SDK Version

No response

API Version

No response

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: MaintenanceAny dependency, housekeeping, and clean up Issue or PR

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions