Fix segfault in lb_get_ble_characteristic_by_uuid

sandeepmistry · arfoll · commit 392128b6b753 · 2017-08-08T12:17:40.000+02:00
Occurs when the first service characteristic UUID doesn't match.

Signed-off-by: Sandeep Mistry &lt;s.mistry@bcmi-labs.cc&gt;
Signed-off-by: Brendan Le Foll &lt;brendan.le.foll@intel.com&gt;
diff --git a/src/littleb.c b/src/littleb.c
@@ -1121,7 +1121,7 @@ lb_get_ble_characteristic_by_uuid(lb_bl_device* dev, const char* uuid, lb_ble_ch
     }
 
     for (i = 0; i < dev->services_size; i++) {
-        for (j = 0; dev->services_size; j++) {
+        for (j = 0; j < dev->services[i]->characteristics_size; j++) {
             if (strncmp(uuid, dev->services[i]->characteristics[j]->uuid, strlen(uuid)) == 0) {
                 *ble_characteristic_ret = dev->services[i]->characteristics[j];
                 return LB_SUCCESS;

Original file line number	Diff line number	Diff line change
`@@ -1121,7 +1121,7 @@ lb_get_ble_characteristic_by_uuid(lb_bl_device* dev, const char* uuid, lb_ble_ch`
`1121`	`1121`	`}`
`1122`	`1122`
`1123`	`1123`	`for (i = 0; i < dev->services_size; i++) {`
`1124`		`- for (j = 0; dev->services_size; j++) {`
	`1124`	`+ for (j = 0; j < dev->services[i]->characteristics_size; j++) {`
`1125`	`1125`	`if (strncmp(uuid, dev->services[i]->characteristics[j]->uuid, strlen(uuid)) == 0) {`
`1126`	`1126`	`*ble_characteristic_ret = dev->services[i]->characteristics[j];`
`1127`	`1127`	`return LB_SUCCESS;`