Skip to content

Commit 06483d2

Browse files
JoseExpositoJiri Kosina
authored andcommitted
HID: uclogic: Use Rx and Ry for touch strips
Currently, HUION devices use ABS_WHEEL as the usage for touch strips. There are 2 main issues with this approach: The first one is that the descriptor for touch rings (uclogic_rdesc_v2_frame_touch_ring_arr) also uses ABS_WHEEL. >From user-space it is impossible to know which device sends the events. The second one is that Wacom uses ABS_RX/ABS_RY to notify events from touch strips and user-space was designed to handle those axes. Change the usage of touch strips to Rx/Ry to fix both issues. Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/989 Signed-off-by: José Expósito <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 48144e8 commit 06483d2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/hid/hid-uclogic-rdesc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,8 @@ const __u8 uclogic_rdesc_v2_frame_touch_strip_arr[] = {
789789
0x95, 0x01, /* Report Count (1), */
790790
0x81, 0x02, /* Input (Variable), */
791791
0x05, 0x01, /* Usage Page (Desktop), */
792-
0x09, 0x38, /* Usage (Wheel), */
792+
0x09, 0x33, /* Usage (Rx), */
793+
0x09, 0x34, /* Usage (Ry), */
793794
0x95, 0x01, /* Report Count (1), */
794795
0x15, 0x00, /* Logical Minimum (0), */
795796
0x25, 0x07, /* Logical Maximum (7), */

0 commit comments

Comments
 (0)