Skip to content

Commit 0bb18e3

Browse files
aborzeszBartosz Golaszewski
authored andcommitted
gpio: graniterapids: Fix GPIO Ack functionality
Interrupt status (GPI_IS) register is cleared by writing 1 to it, not 0. Cc: [email protected] Signed-off-by: Alan Borzeszkowski <[email protected]> Signed-off-by: Mika Westerberg <[email protected]> Acked-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent c0ec489 commit 0bb18e3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpio/gpio-graniterapids.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ static void gnr_gpio_irq_ack(struct irq_data *d)
185185
guard(raw_spinlock_irqsave)(&priv->lock);
186186

187187
reg = readl(addr);
188-
reg &= ~BIT(bit_idx);
188+
reg |= BIT(bit_idx);
189189
writel(reg, addr);
190190
}
191191

0 commit comments

Comments
 (0)