Skip to content

Commit 1c09386

Browse files
superm1alexdeucher
authored andcommitted
drm/amd/display: Fix programming backlight on OLED panels
commit 3807756 ("drm/amd/display: Implement new backlight_level_params structure") adjusted DC core to require the backlight type to be programmed in the dc link when changing brightness. This isn't initialized in amdgpu_dm for OLED panels though which broke brightness. Explicitly initialize when aux support is enabled. Reported-and-tested-by: Luke Jones <[email protected]> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3792 Fixes: 3807756 ("drm/amd/display: Implement new backlight_level_params structure") Reviewed-by: Harry Wentland <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 0f15cbc commit 1c09386

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3481,6 +3481,8 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
34813481
caps->aux_support = false;
34823482
else if (amdgpu_backlight == 1)
34833483
caps->aux_support = true;
3484+
if (caps->aux_support)
3485+
aconnector->dc_link->backlight_control_type = BACKLIGHT_CONTROL_AMD_AUX;
34843486

34853487
luminance_range = &conn_base->display_info.luminance_range;
34863488

0 commit comments

Comments
 (0)