Skip to content

Commit 1fb5cf0

Browse files
jhovoldandersson
authored andcommitted
Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports"
This reverts commit 1a48dd7. A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C ports can break SuperSpeed device hotplugging. The host controller is enumerated, but the device is not: xhci-hcd xhci-hcd.5.auto: xHCI Host Controller xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 3 xhci-hcd xhci-hcd.5.auto: hcc params 0x0110ffc5 hci version 0x110 quirks 0x000080a000000810 xhci-hcd xhci-hcd.5.auto: irq 247, io mem 0x0a800000 xhci-hcd xhci-hcd.5.auto: xHCI Host Controller xhci-hcd xhci-hcd.5.auto: new USB bus registered, assigned bus number 4 xhci-hcd xhci-hcd.5.auto: Host supports USB 3.1 Enhanced SuperSpeed hub 3-0:1.0: USB hub found hub 3-0:1.0: 1 port detected hub 4-0:1.0: USB hub found hub 4-0:1.0: 1 port detected Once this happens on either of the two ports, no amount of disconnecting and reconnecting makes the SuperSpeed device be enumerated, while FullSpeed device enumeration still works. With retimer (and orientation detection) support not even merged yet, let's revert at least until we have stable host mode in mainline. Fixes: 1a48dd7 ("arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports") Cc: Jonathan Marek <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Abel Vesa <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent e60b14f commit 1fb5cf0

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,6 +773,10 @@
773773
status = "okay";
774774
};
775775

776+
&usb_1_ss0_dwc3 {
777+
dr_mode = "host";
778+
};
779+
776780
&usb_1_ss0_dwc3_hs {
777781
remote-endpoint = <&pmic_glink_ss0_hs_in>;
778782
};
@@ -801,6 +805,10 @@
801805
status = "okay";
802806
};
803807

808+
&usb_1_ss1_dwc3 {
809+
dr_mode = "host";
810+
};
811+
804812
&usb_1_ss1_dwc3_hs {
805813
remote-endpoint = <&pmic_glink_ss1_hs_in>;
806814
};

0 commit comments

Comments
 (0)