Skip to content

Commit 21604ed

Browse files
metze-sambasmfrench
authored andcommitted
smb: client: make use of common smbdirect.h
Cc: Steve French <[email protected]> Cc: Tom Talpey <[email protected]> Cc: Long Li <[email protected]> Cc: Namjae Jeon <[email protected]> Cc: Hyunchul Lee <[email protected]> Cc: Meetakshi Setiya <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Stefan Metzmacher <[email protected]> Signed-off-by: Steve French <[email protected]>
1 parent 7e136a7 commit 21604ed

File tree

2 files changed

+9
-15
lines changed

2 files changed

+9
-15
lines changed

fs/smb/client/smb2pdu.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#include "smb2glob.h"
3737
#include "cifspdu.h"
3838
#include "cifs_spnego.h"
39+
#include "../common/smbdirect/smbdirect.h"
3940
#include "smbdirect.h"
4041
#include "trace.h"
4142
#ifdef CONFIG_CIFS_DFS_UPCALL
@@ -4449,10 +4450,10 @@ smb2_new_read_req(void **buf, unsigned int *total_len,
44494450
#ifdef CONFIG_CIFS_SMB_DIRECT
44504451
/*
44514452
* If we want to do a RDMA write, fill in and append
4452-
* smbd_buffer_descriptor_v1 to the end of read request
4453+
* smbdirect_buffer_descriptor_v1 to the end of read request
44534454
*/
44544455
if (rdata && smb3_use_rdma_offload(io_parms)) {
4455-
struct smbd_buffer_descriptor_v1 *v1;
4456+
struct smbdirect_buffer_descriptor_v1 *v1;
44564457
bool need_invalidate = server->dialect == SMB30_PROT_ID;
44574458

44584459
rdata->mr = smbd_register_mr(server->smbd_conn, &rdata->subreq.io_iter,
@@ -4466,8 +4467,8 @@ smb2_new_read_req(void **buf, unsigned int *total_len,
44664467
req->ReadChannelInfoOffset =
44674468
cpu_to_le16(offsetof(struct smb2_read_req, Buffer));
44684469
req->ReadChannelInfoLength =
4469-
cpu_to_le16(sizeof(struct smbd_buffer_descriptor_v1));
4470-
v1 = (struct smbd_buffer_descriptor_v1 *) &req->Buffer[0];
4470+
cpu_to_le16(sizeof(struct smbdirect_buffer_descriptor_v1));
4471+
v1 = (struct smbdirect_buffer_descriptor_v1 *) &req->Buffer[0];
44714472
v1->offset = cpu_to_le64(rdata->mr->mr->iova);
44724473
v1->token = cpu_to_le32(rdata->mr->mr->rkey);
44734474
v1->length = cpu_to_le32(rdata->mr->mr->length);
@@ -4975,10 +4976,10 @@ smb2_async_writev(struct cifs_io_subrequest *wdata)
49754976
#ifdef CONFIG_CIFS_SMB_DIRECT
49764977
/*
49774978
* If we want to do a server RDMA read, fill in and append
4978-
* smbd_buffer_descriptor_v1 to the end of write request
4979+
* smbdirect_buffer_descriptor_v1 to the end of write request
49794980
*/
49804981
if (smb3_use_rdma_offload(io_parms)) {
4981-
struct smbd_buffer_descriptor_v1 *v1;
4982+
struct smbdirect_buffer_descriptor_v1 *v1;
49824983
bool need_invalidate = server->dialect == SMB30_PROT_ID;
49834984

49844985
wdata->mr = smbd_register_mr(server->smbd_conn, &wdata->subreq.io_iter,
@@ -4997,8 +4998,8 @@ smb2_async_writev(struct cifs_io_subrequest *wdata)
49974998
req->WriteChannelInfoOffset =
49984999
cpu_to_le16(offsetof(struct smb2_write_req, Buffer));
49995000
req->WriteChannelInfoLength =
5000-
cpu_to_le16(sizeof(struct smbd_buffer_descriptor_v1));
5001-
v1 = (struct smbd_buffer_descriptor_v1 *) &req->Buffer[0];
5001+
cpu_to_le16(sizeof(struct smbdirect_buffer_descriptor_v1));
5002+
v1 = (struct smbdirect_buffer_descriptor_v1 *) &req->Buffer[0];
50025003
v1->offset = cpu_to_le64(wdata->mr->mr->iova);
50035004
v1->token = cpu_to_le32(wdata->mr->mr->rkey);
50045005
v1->length = cpu_to_le32(wdata->mr->mr->length);

fs/smb/client/smbdirect.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,6 @@ enum smbd_message_type {
177177
SMBD_TRANSFER_DATA,
178178
};
179179

180-
/* The packet fields for a registered RDMA buffer */
181-
struct smbd_buffer_descriptor_v1 {
182-
__le64 offset;
183-
__le32 token;
184-
__le32 length;
185-
} __packed;
186-
187180
/* Maximum number of SGEs used by smbdirect.c in any send work request */
188181
#define SMBDIRECT_MAX_SEND_SGE 6
189182

0 commit comments

Comments
 (0)