Skip to content

Commit 243efbd

Browse files
Zizhi Wotytso
authored andcommitted
ext4: update the comment about mb_optimize_scan
Commit 196e402 ("ext4: improve cr 0 / cr 1 group scanning") introduces the sysfs control interface "mb_max_linear_groups" to address the problem that rotational devices performance degrades when the "mb_optimize_scan" feature is enabled, which may result in distant block group allocation. However, the name of the interface was incorrect in the comment to the ext4/mballoc.c file, and this patch fixes it, without further changes. Signed-off-by: Zizhi Wo <[email protected]> Reviewed-by: Baokun Li <[email protected]> Reviewed-by: Ojaswin Mujoo <[email protected]> Reviewed-by: Zhang Yi <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 18aba2a commit 243efbd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/ext4/mballoc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
* /sys/fs/ext4/<partition>/mb_min_to_scan
188188
* /sys/fs/ext4/<partition>/mb_max_to_scan
189189
* /sys/fs/ext4/<partition>/mb_order2_req
190-
* /sys/fs/ext4/<partition>/mb_linear_limit
190+
* /sys/fs/ext4/<partition>/mb_max_linear_groups
191191
*
192192
* The regular allocator uses buddy scan only if the request len is power of
193193
* 2 blocks and the order of allocation is >= sbi->s_mb_order2_reqs. The
@@ -209,7 +209,7 @@
209209
* get traversed linearly. That may result in subsequent allocations being not
210210
* close to each other. And so, the underlying device may get filled up in a
211211
* non-linear fashion. While that may not matter on non-rotational devices, for
212-
* rotational devices that may result in higher seek times. "mb_linear_limit"
212+
* rotational devices that may result in higher seek times. "mb_max_linear_groups"
213213
* tells mballoc how many groups mballoc should search linearly before
214214
* performing consulting above data structures for more efficient lookups. For
215215
* non rotational devices, this value defaults to 0 and for rotational devices

0 commit comments

Comments
 (0)