Skip to content

Commit 27bba88

Browse files
committed
Merge tag 'drm-misc-next-fixes-2025-06-05' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-next
drm-misc-fixes for v6.16-rc1: - Fixes for nt37801 panel - Fix null deref in HDMI audio helper. - Fixes for analogix_dp. Signed-off-by: Dave Airlie <[email protected]> From: Maarten Lankhorst <[email protected]> Link: https://lore.kernel.org/r/[email protected]
2 parents df9d494 + fd03f82 commit 27bba88

File tree

4 files changed

+12
-17
lines changed

4 files changed

+12
-17
lines changed

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,10 +1531,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
15311531
}
15321532

15331533
dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
1534-
if (IS_ERR(dp->reg_base)) {
1535-
ret = PTR_ERR(dp->reg_base);
1536-
goto err_disable_clk;
1537-
}
1534+
if (IS_ERR(dp->reg_base))
1535+
return ERR_CAST(dp->reg_base);
15381536

15391537
dp->force_hpd = of_property_read_bool(dev->of_node, "force-hpd");
15401538

@@ -1546,8 +1544,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
15461544
if (IS_ERR(dp->hpd_gpiod)) {
15471545
dev_err(dev, "error getting HDP GPIO: %ld\n",
15481546
PTR_ERR(dp->hpd_gpiod));
1549-
ret = PTR_ERR(dp->hpd_gpiod);
1550-
goto err_disable_clk;
1547+
return ERR_CAST(dp->hpd_gpiod);
15511548
}
15521549

15531550
if (dp->hpd_gpiod) {
@@ -1567,8 +1564,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
15671564

15681565
if (dp->irq == -ENXIO) {
15691566
dev_err(&pdev->dev, "failed to get irq\n");
1570-
ret = -ENODEV;
1571-
goto err_disable_clk;
1567+
return ERR_PTR(-ENODEV);
15721568
}
15731569

15741570
ret = devm_request_threaded_irq(&pdev->dev, dp->irq,
@@ -1577,7 +1573,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
15771573
irq_flags, "analogix-dp", dp);
15781574
if (ret) {
15791575
dev_err(&pdev->dev, "failed to request irq\n");
1580-
goto err_disable_clk;
1576+
return ERR_PTR(ret);
15811577
}
15821578

15831579
dp->aux.name = "DP-AUX";
@@ -1590,13 +1586,9 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
15901586
pm_runtime_set_autosuspend_delay(dp->dev, 100);
15911587
ret = devm_pm_runtime_enable(dp->dev);
15921588
if (ret)
1593-
goto err_disable_clk;
1589+
return ERR_PTR(ret);
15941590

15951591
return dp;
1596-
1597-
err_disable_clk:
1598-
clk_disable_unprepare(dp->clock);
1599-
return ERR_PTR(ret);
16001592
}
16011593
EXPORT_SYMBOL_GPL(analogix_dp_probe);
16021594

drivers/gpu/drm/display/drm_hdmi_audio_helper.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ static int drm_connector_hdmi_audio_hook_plugged_cb(struct device *dev,
103103
connector->hdmi_audio.plugged_cb = fn;
104104
connector->hdmi_audio.plugged_cb_dev = codec_dev;
105105

106-
fn(codec_dev, connector->hdmi_audio.last_state);
106+
if (fn)
107+
fn(codec_dev, connector->hdmi_audio.last_state);
107108

108109
mutex_unlock(&connector->hdmi_audio.lock);
109110

drivers/gpu/drm/panel/Kconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,8 @@ config DRM_PANEL_NOVATEK_NT37801
522522
depends on OF
523523
depends on DRM_MIPI_DSI
524524
depends on BACKLIGHT_CLASS_DEVICE
525+
select DRM_DISPLAY_DSC_HELPER
526+
select DRM_DISPLAY_HELPER
525527
help
526528
Say Y here if you want to enable support for Novatek NT37801 (or
527529
NT37810) AMOLED DSI Video Mode LCD panel module with 1440x3200

drivers/gpu/drm/panel/panel-novatek-nt37801.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,8 @@ static int novatek_nt37801_probe(struct mipi_dsi_device *dsi)
257257
ctx = devm_drm_panel_alloc(dev, struct novatek_nt37801, panel,
258258
&novatek_nt37801_panel_funcs,
259259
DRM_MODE_CONNECTOR_DSI);
260-
if (!ctx)
261-
return -ENOMEM;
260+
if (IS_ERR(ctx))
261+
return PTR_ERR(ctx);
262262

263263
ret = devm_regulator_bulk_get_const(dev,
264264
ARRAY_SIZE(novatek_nt37801_supplies),

0 commit comments

Comments
 (0)