@@ -90,24 +90,6 @@ struct mptcp_storage {
9090 char ca_name [TCP_CA_NAME_MAX ];
9191};
9292
93- static struct nstoken * create_netns (void )
94- {
95- SYS (fail , "ip netns add %s" , NS_TEST );
96- SYS (fail , "ip -net %s link set dev lo up" , NS_TEST );
97-
98- return open_netns (NS_TEST );
99- fail :
100- return NULL ;
101- }
102-
103- static void cleanup_netns (struct nstoken * nstoken )
104- {
105- if (nstoken )
106- close_netns (nstoken );
107-
108- SYS_NOFAIL ("ip netns del %s" , NS_TEST );
109- }
110-
11193static int start_mptcp_server (int family , const char * addr_str , __u16 port ,
11294 int timeout_ms )
11395{
@@ -227,15 +209,15 @@ static int run_test(int cgroup_fd, int server_fd, bool is_mptcp)
227209
228210static void test_base (void )
229211{
230- struct nstoken * nstoken = NULL ;
212+ struct netns_obj * netns = NULL ;
231213 int server_fd , cgroup_fd ;
232214
233215 cgroup_fd = test__join_cgroup ("/mptcp" );
234216 if (!ASSERT_GE (cgroup_fd , 0 , "test__join_cgroup" ))
235217 return ;
236218
237- nstoken = create_netns ( );
238- if (!ASSERT_OK_PTR (nstoken , "create_netns " ))
219+ netns = netns_new ( NS_TEST , true );
220+ if (!ASSERT_OK_PTR (netns , "netns_new " ))
239221 goto fail ;
240222
241223 /* without MPTCP */
@@ -258,7 +240,7 @@ static void test_base(void)
258240 close (server_fd );
259241
260242fail :
261- cleanup_netns ( nstoken );
243+ netns_free ( netns );
262244 close (cgroup_fd );
263245}
264246
@@ -343,21 +325,21 @@ static int run_mptcpify(int cgroup_fd)
343325
344326static void test_mptcpify (void )
345327{
346- struct nstoken * nstoken = NULL ;
328+ struct netns_obj * netns = NULL ;
347329 int cgroup_fd ;
348330
349331 cgroup_fd = test__join_cgroup ("/mptcpify" );
350332 if (!ASSERT_GE (cgroup_fd , 0 , "test__join_cgroup" ))
351333 return ;
352334
353- nstoken = create_netns ( );
354- if (!ASSERT_OK_PTR (nstoken , "create_netns " ))
335+ netns = netns_new ( NS_TEST , true );
336+ if (!ASSERT_OK_PTR (netns , "netns_new " ))
355337 goto fail ;
356338
357339 ASSERT_OK (run_mptcpify (cgroup_fd ), "run_mptcpify" );
358340
359341fail :
360- cleanup_netns ( nstoken );
342+ netns_free ( netns );
361343 close (cgroup_fd );
362344}
363345
@@ -473,7 +455,7 @@ static void run_subflow(void)
473455static void test_subflow (void )
474456{
475457 struct mptcp_subflow * skel ;
476- struct nstoken * nstoken ;
458+ struct netns_obj * netns ;
477459 int cgroup_fd ;
478460
479461 cgroup_fd = test__join_cgroup ("/mptcp_subflow" );
@@ -496,8 +478,8 @@ static void test_subflow(void)
496478 if (!ASSERT_OK_PTR (skel -> links ._getsockopt_subflow , "attach _getsockopt_subflow" ))
497479 goto skel_destroy ;
498480
499- nstoken = create_netns ( );
500- if (!ASSERT_OK_PTR (nstoken , "create_netns : mptcp_subflow" ))
481+ netns = netns_new ( NS_TEST , true );
482+ if (!ASSERT_OK_PTR (netns , "netns_new : mptcp_subflow" ))
501483 goto skel_destroy ;
502484
503485 if (endpoint_init ("subflow" , 2 ) < 0 )
@@ -506,7 +488,7 @@ static void test_subflow(void)
506488 run_subflow ();
507489
508490close_netns :
509- cleanup_netns ( nstoken );
491+ netns_free ( netns );
510492skel_destroy :
511493 mptcp_subflow__destroy (skel );
512494close_cgroup :
0 commit comments